Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: net/proxy/proxy_resolver.h

Issue 1157163003: Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-proxy-resolver-refactor
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/multi_threaded_proxy_resolver_unittest.cc ('k') | net/proxy/proxy_resolver_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver.h
diff --git a/net/proxy/proxy_resolver.h b/net/proxy/proxy_resolver.h
index bae5186e4457e1d732f54ccae26ba6248a969b4f..11df64fcc6a1e565de86d3c2e0b1cb262368c529 100644
--- a/net/proxy/proxy_resolver.h
+++ b/net/proxy/proxy_resolver.h
@@ -32,9 +32,7 @@ class NET_EXPORT_PRIVATE ProxyResolver {
using LoadStateChangedCallback =
base::Callback<void(RequestHandle, LoadState)>;
- // See |expects_pac_bytes()| for the meaning of |expects_pac_bytes|.
- explicit ProxyResolver(bool expects_pac_bytes)
- : expects_pac_bytes_(expects_pac_bytes) {}
+ ProxyResolver() {}
virtual ~ProxyResolver() {}
@@ -56,24 +54,7 @@ class NET_EXPORT_PRIVATE ProxyResolver {
// Gets the LoadState for |request|.
virtual LoadState GetLoadState(RequestHandle request) const = 0;
- // The PAC script backend can be specified to the ProxyResolver either via
- // URL, or via the javascript text itself. If |expects_pac_bytes| is true,
- // then the ProxyResolverScriptData passed to SetPacScript() should
- // contain the actual script bytes rather than just the URL.
- bool expects_pac_bytes() const { return expects_pac_bytes_; }
-
- virtual void CancelSetPacScript() = 0;
-
- // Called to set the PAC script backend to use.
- // Returns ERR_IO_PENDING in the case of asynchronous completion, and notifies
- // the result through |callback|.
- virtual int SetPacScript(
- const scoped_refptr<ProxyResolverScriptData>& pac_script,
- const CompletionCallback& callback) = 0;
-
private:
- const bool expects_pac_bytes_;
-
DISALLOW_COPY_AND_ASSIGN(ProxyResolver);
};
« no previous file with comments | « net/proxy/multi_threaded_proxy_resolver_unittest.cc ('k') | net/proxy/proxy_resolver_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698