Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: net/proxy/proxy_resolver_mac.cc

Issue 1157163003: Remove ProxyResolver::(Cancel)SetPacScript and LegacyProxyResolverFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-proxy-resolver-refactor
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_resolver_factory_unittest.cc ('k') | net/proxy/proxy_resolver_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver_mac.cc
diff --git a/net/proxy/proxy_resolver_mac.cc b/net/proxy/proxy_resolver_mac.cc
index 521bd6a7a4a7c34054cb5611ff91256caa2e0fd1..df438d198283bac837007dce93a669d12b7db087 100644
--- a/net/proxy/proxy_resolver_mac.cc
+++ b/net/proxy/proxy_resolver_mac.cc
@@ -80,18 +80,13 @@ class ProxyResolverMac : public ProxyResolver {
LoadState GetLoadState(RequestHandle request) const override;
- void CancelSetPacScript() override;
-
- int SetPacScript(const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& /*callback*/) override;
-
private:
const scoped_refptr<ProxyResolverScriptData> script_data_;
};
ProxyResolverMac::ProxyResolverMac(
const scoped_refptr<ProxyResolverScriptData>& script_data)
- : ProxyResolver(false /*expects_pac_bytes*/), script_data_(script_data) {
+ : script_data_(script_data) {
}
ProxyResolverMac::~ProxyResolverMac() {}
@@ -215,17 +210,6 @@ LoadState ProxyResolverMac::GetLoadState(RequestHandle request) const {
return LOAD_STATE_IDLE;
}
-void ProxyResolverMac::CancelSetPacScript() {
- NOTREACHED();
-}
-
-int ProxyResolverMac::SetPacScript(
- const scoped_refptr<ProxyResolverScriptData>& script_data,
- const CompletionCallback& /*callback*/) {
- NOTREACHED();
- return ERR_NOT_IMPLEMENTED;
-}
-
} // namespace
ProxyResolverFactoryMac::ProxyResolverFactoryMac()
« no previous file with comments | « net/proxy/proxy_resolver_factory_unittest.cc ('k') | net/proxy/proxy_resolver_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698