runtime/vm/assembler_ia32.h - Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_ia32.h

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_ia32.h

diff --git a/runtime/vm/assembler_ia32.h b/runtime/vm/assembler_ia32.h

index e00528a506a6540e9152894161e7ce231bf9a494..3bb27c92c96734c964e0ce767673932ce9b399dd 100644

--- a/runtime/vm/assembler_ia32.h

+++ b/runtime/vm/assembler_ia32.h

@@ -848,6 +848,7 @@ class Assembler : public ValueObject {

// pushl immediate(0)

// .....

void EnterStubFrame();

+ static const intptr_t kEnterStubFramePushedWords = 2;

// Instruction pattern from entrypoint is used in dart frame prologs

// to set up the frame and save a PC which can be used to figure out the

« no previous file with comments | « runtime/vm/assembler_arm_test.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')