Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: runtime/vm/assembler_arm_test.cc

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm_test.cc
diff --git a/runtime/vm/assembler_arm_test.cc b/runtime/vm/assembler_arm_test.cc
index a5292148754808fe88455f09e5d100fb085b5795..2cc40fdeb9a0c1b4ad65cbd1986ef3b12823473c 100644
--- a/runtime/vm/assembler_arm_test.cc
+++ b/runtime/vm/assembler_arm_test.cc
@@ -3931,13 +3931,15 @@ ASSEMBLER_TEST_RUN(Vnegqs, test) {
// R0: context.
// R1: value.
// R2: growable array.
+// R3: current thread.
ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
- __ PushList((1 << CTX) | (1 << LR));
+ __ PushList((1 << CTX) | (1 << LR) | (1 << THR));
__ mov(CTX, Operand(R0));
+ __ mov(THR, Operand(R3));
__ StoreIntoObject(R2,
FieldAddress(R2, GrowableObjectArray::data_offset()),
R1);
- __ PopList((1 << CTX) | (1 << LR));
+ __ PopList((1 << CTX) | (1 << LR) | (1 << THR));
__ Ret();
}

Powered by Google App Engine
This is Rietveld 408576698