runtime/vm/assembler_ia32.cc - Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_ia32.cc

diff --git a/runtime/vm/assembler_ia32.cc b/runtime/vm/assembler_ia32.cc

index d876feb77f784077d02a36cbdabc5abe19c07c57..6e6d0d6d4db7ffff304b1a603239e0da9764f7cd 100644

--- a/runtime/vm/assembler_ia32.cc

+++ b/runtime/vm/assembler_ia32.cc

@@ -2124,7 +2124,7 @@ void Assembler::Drop(intptr_t stack_elements) {

void Assembler::LoadIsolate(Register dst) {

- movl(dst, Immediate(reinterpret_cast<uword>(Isolate::Current())));

+ movl(dst, Address(THR, Thread::isolate_offset()));

}

« no previous file with comments | « runtime/vm/assembler_ia32.h ('k') | runtime/vm/assembler_ia32_test.cc » ('j') | runtime/vm/flow_graph_compiler.cc » ('J')