runtime/vm/flow_graph_compiler.cc - Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Address review comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index ae31c415a40a9e13c5b5fd7f7be16c903418a41b..2c21416b93be072dc1e4c2f2087839ee03912787 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -1241,6 +1241,7 @@ void FlowGraphCompiler::AllocateRegistersLocally(Instruction* instr) {

if (PP != kNoRegister) {

blocked_registers[PP] = true;

}

+ blocked_registers[THR] = true;

// Block all non-free registers.

for (intptr_t i = 0; i < kFirstFreeCpuRegister; i++) {

« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | no next file with comments »