Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: runtime/vm/assembler_ia32_test.cc

Issue 1156593002: Cache current thread in a reserved register and use it in LoadIsolate (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_ia32_test.cc
diff --git a/runtime/vm/assembler_ia32_test.cc b/runtime/vm/assembler_ia32_test.cc
index 2fd286621067807566aed22a0db9702740532592..b5415740eec97a438cce4ad15b6f99d63b73d0f6 100644
--- a/runtime/vm/assembler_ia32_test.cc
+++ b/runtime/vm/assembler_ia32_test.cc
@@ -3393,16 +3393,19 @@ ASSEMBLER_TEST_RUN(TestRepMovsBytes, test) {
// Called from assembler_test.cc.
ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
+ __ pushl(THR);
__ pushl(CTX);
- __ movl(CTX, Address(ESP, 2 * kWordSize));
- __ movl(EAX, Address(ESP, 3 * kWordSize));
- __ movl(ECX, Address(ESP, 4 * kWordSize));
+ __ movl(CTX, Address(ESP, 3 * kWordSize));
+ __ movl(EAX, Address(ESP, 4 * kWordSize));
+ __ movl(ECX, Address(ESP, 5 * kWordSize));
+ __ movl(THR, Address(ESP, 6 * kWordSize));
__ pushl(EAX);
__ StoreIntoObject(ECX,
FieldAddress(ECX, GrowableObjectArray::data_offset()),
EAX);
__ popl(EAX);
__ popl(CTX);
+ __ popl(THR);
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698