Revert of Embedded constant pools.

Revert of Embedded constant pools. (patchset #12 id:220001 of https://codereview.chromium.org/1131783003/)

Reason for revert:
Breaks Linux nosnap cctest/test-api/FastReturnValuesWithProfiler, see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/609/steps/Check/logs/FastReturnValuesWithP..

Original issue's description:
> Add support for Embedded Constant Pools for PPC and Arm
>
> Embed constant pools within their corresponding Code
> objects.
>
> This removes support for out-of-line constant pools in favor
> of the new approach -- the main advantage being that it
> eliminates the need to allocate and manage separate constant
> pool array objects.
>
> Currently supported on PPC and ARM.  Enabled by default on
> PPC only.
>
> This yields a 6% improvment in Octane on PPC64.
>
> R=danno@chromium.org, svenpanne@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com
> BUG=chromium:478811
> LOG=Y
>
> Committed: https://crrev.com/a9404029343d65f146e3443f5280c40a97e736af
> Cr-Commit-Position: refs/heads/master@{#28770}

TBR=rmcilroy@chromium.org,ishell@chromium.org,rodolph.perfetta@arm.com,mbrandy@us.ibm.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:478811
Committed: https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
Cr-Commit-Position: refs/heads/master@{#28772}

[Benedikt Meurer, 2015-06-03 03:00:53]

Created Revert of Embedded constant pools.

[commit-bot: I haz the power, 2015-06-03 03:01:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155703006/1

[commit-bot: I haz the power, 2015-06-03 03:02:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-03 03:02:50]

Patchset 1 (id:??) landed as
https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
Cr-Commit-Position: refs/heads/master@{#28772}

[MTBrandyberry, 2015-06-03 15:44:26]

On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> Cr-Commit-Position: refs/heads/master@{#28772}

It's not obvious how this change could have broken this since it should be
mostly a no-op for ia32.  Are there build artifacts available that I can use to
reproduce the problem and debug?

[rmcilroy, 2015-06-03 15:54:32]

On 2015/06/03 15:44:26, mtbrandyberry wrote:
> On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> > Cr-Commit-Position: refs/heads/master@{#28772}
> 
> It's not obvious how this change could have broken this since it should be
> mostly a no-op for ia32.  Are there build artifacts available that I can use
to
> reproduce the problem and debug?

You can see the build logs here:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...

You can recreate the build locally by building with something like:

make ia32.debug snapshot=off

[MTBrandyberry, 2015-06-03 16:50:41]

On 2015/06/03 15:54:32, rmcilroy wrote:
> On 2015/06/03 15:44:26, mtbrandyberry wrote:
> > On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> > > Cr-Commit-Position: refs/heads/master@{#28772}
> > 
> > It's not obvious how this change could have broken this since it should be
> > mostly a no-op for ia32.  Are there build artifacts available that I can use
> to
> > reproduce the problem and debug?
> 
> You can see the build logs here:
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
> 
> You can recreate the build locally by building with something like:
> 
> make ia32.debug snapshot=off

I'm not able to reproduce this:

$ git log --pretty=oneline -n1
a9404029343d65f146e3443f5280c40a97e736af Add support for Embedded Constant Pools
for PPC and Arm

$ make ia32.debug snapshot=off
<...>

$ out/ia32.debug/cctest --random-seed=-2035604219 --stress-opt --always-opt
test-api/FastReturnValuesWithProfiler --nohard-abort --nodead-code-elimination
--nofold-constants --enable-slow-asserts --debug-code --verify-heap
--testing_serialization_file=out/.serdes/serdes_FastReturnValuesWithProfiler__stress_opt__always_opt
$

[rmcilroy, 2015-06-03 17:02:50]

On 2015/06/03 16:50:41, mtbrandyberry wrote:
> On 2015/06/03 15:54:32, rmcilroy wrote:
> > On 2015/06/03 15:44:26, mtbrandyberry wrote:
> > > On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> > > > Patchset 1 (id:??) landed as
> > > > https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> > > > Cr-Commit-Position: refs/heads/master@{#28772}
> > > 
> > > It's not obvious how this change could have broken this since it should be
> > > mostly a no-op for ia32.  Are there build artifacts available that I can
use
> > to
> > > reproduce the problem and debug?
> > 
> > You can see the build logs here:
> >
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
> > 
> > You can recreate the build locally by building with something like:
> > 
> > make ia32.debug snapshot=off
> 
> I'm not able to reproduce this:
> 
> $ git log --pretty=oneline -n1
> a9404029343d65f146e3443f5280c40a97e736af Add support for Embedded Constant
Pools
> for PPC and Arm
> 
> $ make ia32.debug snapshot=off
> <...>
> 
> $ out/ia32.debug/cctest --random-seed=-2035604219 --stress-opt --always-opt
> test-api/FastReturnValuesWithProfiler --nohard-abort --nodead-code-elimination
> --nofold-constants --enable-slow-asserts --debug-code --verify-heap
>
--testing_serialization_file=out/.serdes/serdes_FastReturnValuesWithProfiler__stress_opt__always_opt
> $

Benedikt: This only happened once on the bot from what I can see.  Are you sure
it wasn't just flake?

[MTBrandyberry, 2015-06-03 19:16:53]

On 2015/06/03 17:02:50, rmcilroy wrote:
> On 2015/06/03 16:50:41, mtbrandyberry wrote:
> > On 2015/06/03 15:54:32, rmcilroy wrote:
> > > On 2015/06/03 15:44:26, mtbrandyberry wrote:
> > > > On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> > > > > Patchset 1 (id:??) landed as
> > > > > https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> > > > > Cr-Commit-Position: refs/heads/master@{#28772}
> > > > 
> > > > It's not obvious how this change could have broken this since it should
be
> > > > mostly a no-op for ia32.  Are there build artifacts available that I can
> use
> > > to
> > > > reproduce the problem and debug?
> > > 
> > > You can see the build logs here:
> > >
> >
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
> > > 
> > > You can recreate the build locally by building with something like:
> > > 
> > > make ia32.debug snapshot=off
> > 
> > I'm not able to reproduce this:
> > 
> > $ git log --pretty=oneline -n1
> > a9404029343d65f146e3443f5280c40a97e736af Add support for Embedded Constant
> Pools
> > for PPC and Arm
> > 
> > $ make ia32.debug snapshot=off
> > <...>
> > 
> > $ out/ia32.debug/cctest --random-seed=-2035604219 --stress-opt --always-opt
> > test-api/FastReturnValuesWithProfiler --nohard-abort
--nodead-code-elimination
> > --nofold-constants --enable-slow-asserts --debug-code --verify-heap
> >
>
--testing_serialization_file=out/.serdes/serdes_FastReturnValuesWithProfiler__stress_opt__always_opt
> > $
> 
> Benedikt: This only happened once on the bot from what I can see.  Are you
sure
> it wasn't just flake?

I've been running this in a loop on various machines all afternoon without
reproducing.  I've tried the commit referenced above, the one immediately after
(where the bot reported it), and the latest code with the constant pool change
re-applied.  No failures.

[rmcilroy, 2015-06-04 13:48:37]

On 2015/06/03 19:16:53, mtbrandyberry wrote:
> On 2015/06/03 17:02:50, rmcilroy wrote:
> > On 2015/06/03 16:50:41, mtbrandyberry wrote:
> > > On 2015/06/03 15:54:32, rmcilroy wrote:
> > > > On 2015/06/03 15:44:26, mtbrandyberry wrote:
> > > > > On 2015/06/03 03:02:50, commit-bot: I haz the power wrote:
> > > > > > Patchset 1 (id:??) landed as
> > > > > > https://crrev.com/51439db3b287faed806e9a1cae33bc3498feeaf6
> > > > > > Cr-Commit-Position: refs/heads/master@{#28772}
> > > > > 
> > > > > It's not obvious how this change could have broken this since it
should
> be
> > > > > mostly a no-op for ia32.  Are there build artifacts available that I
can
> > use
> > > > to
> > > > > reproduce the problem and debug?
> > > > 
> > > > You can see the build logs here:
> > > >
> > >
> >
>
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...
> > > > 
> > > > You can recreate the build locally by building with something like:
> > > > 
> > > > make ia32.debug snapshot=off
> > > 
> > > I'm not able to reproduce this:
> > > 
> > > $ git log --pretty=oneline -n1
> > > a9404029343d65f146e3443f5280c40a97e736af Add support for Embedded Constant
> > Pools
> > > for PPC and Arm
> > > 
> > > $ make ia32.debug snapshot=off
> > > <...>
> > > 
> > > $ out/ia32.debug/cctest --random-seed=-2035604219 --stress-opt
--always-opt
> > > test-api/FastReturnValuesWithProfiler --nohard-abort
> --nodead-code-elimination
> > > --nofold-constants --enable-slow-asserts --debug-code --verify-heap
> > >
> >
>
--testing_serialization_file=out/.serdes/serdes_FastReturnValuesWithProfiler__stress_opt__always_opt
> > > $
> > 
> > Benedikt: This only happened once on the bot from what I can see.  Are you
> sure
> > it wasn't just flake?
> 
> I've been running this in a loop on various machines all afternoon without
> reproducing.  I've tried the commit referenced above, the one immediately
after
> (where the bot reported it), and the latest code with the constant pool change
> re-applied.  No failures.

Let's assume this was flake. Go ahead and reland your CL and keep an eye on this
specific bot when you do so in case it turns out to be something which only
repos on the bot.