Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1154783003: Revert of Use CLOCK_REALTIME_COARSE when available. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use CLOCK_REALTIME_COARSE when available. (patchset #1 id:1 of https://codereview.chromium.org/1151283005/) Reason for revert: [Sheriff] This leads to several failures in chromium and blocks our roll: https://codereview.chromium.org/1154363002/ Bisect (https://codereview.chromium.org/1152553004/) points to this CL. Please add the failing chromium trybot on a reland of this CL. Original issue's description: > Use CLOCK_REALTIME_COARSE when available. > > On systems that have CLOCK_REALTIME_COARSE with good enough resolution, > we can avoid making a system call to get the current time; it's serviced > from the vDSO. > > This is v2 of the patch. v1 can be found at [0] but was reverted in [1] > because of Chromium sandbox restrictions. The necessary changes have > been applied upstream in [2]. > > [0] https://codereview.chromium.org/1125003002 > [1] https://codereview.chromium.org/1130083003 > [2] https://codereview.chromium.org/1133653002 > > BUG= > LOG=N > > Committed: https://crrev.com/28cea2b749f24ba33e6e0c8e343dd0d6258ee302 > Cr-Commit-Position: refs/heads/master@{#28639} TBR=jochen@chromium.org,bmeurer@chromium.org,ben@strongloop.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9cc183d8996948d71660a8b1dbddfeaee2f79ada Cr-Commit-Position: refs/heads/master@{#28656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M src/base/platform/time.cc View 2 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael Achenbach
Created Revert of Use CLOCK_REALTIME_COARSE when available.
5 years, 6 months ago (2015-05-27 14:05:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154783003/1
5 years, 6 months ago (2015-05-27 14:05:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-27 14:05:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9cc183d8996948d71660a8b1dbddfeaee2f79ada Cr-Commit-Position: refs/heads/master@{#28656}
5 years, 6 months ago (2015-05-27 14:06:10 UTC) #4
noordhuis
On 2015/05/27 14:05:25, Michael Achenbach wrote: > Created Revert of Use CLOCK_REALTIME_COARSE when available. Okay, ...
5 years, 6 months ago (2015-05-27 15:42:46 UTC) #5
noordhuis
On 2015/05/27 15:42:46, noordhuis wrote: > On 2015/05/27 14:05:25, Michael Achenbach wrote: > > Created ...
5 years, 6 months ago (2015-05-28 17:59:54 UTC) #6
Jakob Kummerow
On 2015/05/28 17:59:54, noordhuis wrote: > On 2015/05/27 15:42:46, noordhuis wrote: > > On 2015/05/27 ...
5 years, 6 months ago (2015-06-01 11:30:58 UTC) #7
Jakob Kummerow
On 2015/05/28 17:59:54, noordhuis wrote: > On 2015/05/27 15:42:46, noordhuis wrote: > > On 2015/05/27 ...
5 years, 6 months ago (2015-06-01 11:31:42 UTC) #8
noordhuis
On 2015/06/01 11:31:42, Jakob wrote: > On 2015/05/28 17:59:54, noordhuis wrote: > > On 2015/05/27 ...
5 years, 6 months ago (2015-06-01 12:20:19 UTC) #9
Michael Achenbach
5 years, 5 months ago (2015-07-02 13:55:33 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1217543005/ by machenbach@chromium.org.

The reason for reverting is: Experimental reland.

Powered by Google App Engine
This is Rietveld 408576698