Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1151283005: Use CLOCK_REALTIME_COARSE when available. (Closed)

Created:
5 years, 6 months ago by bnoordhuis
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use CLOCK_REALTIME_COARSE when available. On systems that have CLOCK_REALTIME_COARSE with good enough resolution, we can avoid making a system call to get the current time; it's serviced from the vDSO. This is v2 of the patch. v1 can be found at [0] but was reverted in [1] because of Chromium sandbox restrictions. The necessary changes have been applied upstream in [2]. [0] https://codereview.chromium.org/1125003002 [1] https://codereview.chromium.org/1130083003 [2] https://codereview.chromium.org/1133653002 BUG= LOG=N Committed: https://crrev.com/28cea2b749f24ba33e6e0c8e343dd0d6258ee302 Cr-Commit-Position: refs/heads/master@{#28639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M src/base/platform/time.cc View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bnoordhuis
I included the suggestion from the original CL to use NoBarrier_Load() and NoBarrier_Store(). It's perhaps ...
5 years, 6 months ago (2015-05-25 15:32:36 UTC) #2
jochen (gone - plz use gerrit)
+bmeurer
5 years, 6 months ago (2015-05-26 15:45:07 UTC) #4
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-05-26 17:43:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151283005/1
5 years, 6 months ago (2015-05-26 17:43:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-26 18:10:39 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28cea2b749f24ba33e6e0c8e343dd0d6258ee302 Cr-Commit-Position: refs/heads/master@{#28639}
5 years, 6 months ago (2015-05-26 18:10:54 UTC) #9
Michael Achenbach
5 years, 6 months ago (2015-05-27 14:05:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1154783003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This leads to several failures in
chromium and blocks our roll:
https://codereview.chromium.org/1154363002/

Bisect (https://codereview.chromium.org/1152553004/) points to this CL.

Please add the failing chromium trybot on a reland of this CL..

Powered by Google App Engine
This is Rietveld 408576698