Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1133653002: Allow coarse clocks in clock_get{res,time} calls. (Closed)

Created:
5 years, 7 months ago by bnoordhuis
Modified:
5 years, 7 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow coarse clocks in clock_get{res,time} calls. Whitelist CLOCK_MONOTONIC_COARSE and CLOCK_REALTIME_COARSE so we can improve the performance of Date.now() in V8. See https://codereview.chromium.org/1125003002/ for background. BUG= Committed: https://crrev.com/7598f464dda3b851eeb77b7d1083d5926a823acf Cr-Commit-Position: refs/heads/master@{#331201}

Patch Set 1 #

Patch Set 2 : Allow coarse clocks in clock_get{res,time} calls, v2 #

Total comments: 1

Patch Set 3 : Allow coarse clocks in clock_get{res,time} calls, v3 #

Patch Set 4 : Allow coarse clocks in clock_get{res,time} calls, v4 #

Patch Set 5 : Allow coarse clocks in clock_get{res,time} calls, v5 #

Patch Set 6 : Allow coarse clocks in clock_get{res,time} calls, v6 #

Patch Set 7 : Allow coarse clocks in clock_get{res,time} calls, v7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M AUTHORS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
A sandbox/linux/system_headers/linux_time.h View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (10 generated)
noordhuis
PTAL. I'm not listed in AUTHORS but there is a CLA of me on file.
5 years, 7 months ago (2015-05-07 15:37:59 UTC) #2
mdempsky
On 2015/05/07 15:37:59, noordhuis wrote: > PTAL. I'm not listed in AUTHORS but there is ...
5 years, 7 months ago (2015-05-07 18:57:01 UTC) #3
mdempsky
NOT LGTM
5 years, 7 months ago (2015-05-07 18:57:13 UTC) #4
noordhuis
On 2015/05/07 18:57:01, mdempsky wrote: > On 2015/05/07 15:37:59, noordhuis wrote: > > PTAL. I'm ...
5 years, 7 months ago (2015-05-07 19:08:49 UTC) #5
jln (very slow on Chromium)
https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc File sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc (right): https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc#newcode67 sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc:67: ts.tv_sec = ts.tv_nsec = -1; Style: please break in ...
5 years, 7 months ago (2015-05-07 19:22:41 UTC) #7
noordhuis
On 2015/05/07 19:22:41, jln wrote: > https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc > File > sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc > (right): > > ...
5 years, 7 months ago (2015-05-07 19:26:09 UTC) #8
jln (very slow on Chromium)
On 2015/05/07 19:26:09, noordhuis wrote: > On 2015/05/07 19:22:41, jln wrote: > > > https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc ...
5 years, 7 months ago (2015-05-07 19:27:07 UTC) #9
noordhuis
Done, PTAL.
5 years, 7 months ago (2015-05-07 19:35:30 UTC) #10
mdempsky
On 2015/05/07 19:35:30, noordhuis wrote: > Done, PTAL. LGTM, thanks! (Also verified that you have ...
5 years, 7 months ago (2015-05-07 19:47:38 UTC) #11
mdempsky
Looks like CLOCK_{MONOTONIC,REALTIME}_COARSE aren't defined on all of the buildbots. We probably need to add ...
5 years, 7 months ago (2015-05-07 20:06:31 UTC) #12
noordhuis
I've just uploaded a new patch that does just that. Can you PTAL? I added ...
5 years, 7 months ago (2015-05-07 20:16:32 UTC) #13
mdempsky
On 2015/05/07 20:16:32, noordhuis wrote: > I added the guards in syscall_parameters_restrictions.cc and > syscall_parameters_restrictions_unittests.cc ...
5 years, 7 months ago (2015-05-07 20:23:55 UTC) #14
noordhuis
On 2015/05/07 20:23:55, mdempsky wrote: > Hm. I'd suggest creating a sandbox/linux/system_headers/linux_time.h file and > ...
5 years, 7 months ago (2015-05-07 20:38:13 UTC) #15
mdempsky
LGTM
5 years, 7 months ago (2015-05-07 20:40:36 UTC) #16
noordhuis
This CL seems to have run aground on what appears to be unrelated test failures. ...
5 years, 7 months ago (2015-05-11 13:47:34 UTC) #17
mdempsky
On 2015/05/11 13:47:34, noordhuis wrote: > This CL seems to have run aground on what ...
5 years, 7 months ago (2015-05-11 17:15:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133653002/100001
5 years, 7 months ago (2015-05-11 17:16:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62641)
5 years, 7 months ago (2015-05-11 17:46:17 UTC) #24
noordhuis
On 2015/05/11 17:46:17, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 7 months ago (2015-05-11 17:54:52 UTC) #25
mdempsky
On 2015/05/11 17:54:52, noordhuis wrote: > It's checking my corporate email address, mailto:ben@strongloop.com, now... I'm ...
5 years, 7 months ago (2015-05-11 18:03:35 UTC) #26
bnoordhuis
Sorry for the delay; between holidays and meetings, this kind of fell by the wayside. ...
5 years, 7 months ago (2015-05-19 12:24:34 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133653002/120001
5 years, 7 months ago (2015-05-21 15:04:30 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/78979)
5 years, 7 months ago (2015-05-21 17:53:53 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133653002/120001
5 years, 7 months ago (2015-05-22 21:42:45 UTC) #34
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-05-22 23:19:59 UTC) #35
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 23:21:47 UTC) #36
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/7598f464dda3b851eeb77b7d1083d5926a823acf
Cr-Commit-Position: refs/heads/master@{#331201}

Powered by Google App Engine
This is Rietveld 408576698