Allow coarse clocks in clock_get{res,time} calls.

Allow coarse clocks in clock_get{res,time} calls.

Whitelist CLOCK_MONOTONIC_COARSE and CLOCK_REALTIME_COARSE so we can improve
the performance of Date.now() in V8.

See https://codereview.chromium.org/1125003002/ for background.

BUG=

Committed: https://crrev.com/7598f464dda3b851eeb77b7d1083d5926a823acf
Cr-Commit-Position: refs/heads/master@{#331201}

[noordhuis, 2015-05-07 15:37:59]

info@bnoordhuis.nl changed reviewers:
+ info@bnoordhuis.nl, mdempsky@chromium.org

[noordhuis, 2015-05-07 15:37:59]

PTAL.  I'm not listed in AUTHORS but there is a CLA of me on file.

[mdempsky, 2015-05-07 18:57:01]

On 2015/05/07 15:37:59, noordhuis wrote:
> PTAL.  I'm not listed in AUTHORS but there is a CLA of me on file.

This change seems fine to me, but you need to add yourself to the AUTHORS file
before I can LGTM.  See: https://www.chromium.org/developers/contributing-code

[mdempsky, 2015-05-07 18:57:13]

NOT LGTM

[noordhuis, 2015-05-07 19:08:49]

On 2015/05/07 18:57:01, mdempsky wrote:
> On 2015/05/07 15:37:59, noordhuis wrote:
> > PTAL.  I'm not listed in AUTHORS but there is a CLA of me on file.
> 
> This change seems fine to me, but you need to add yourself to the AUTHORS file
> before I can LGTM.  See: https://www.chromium.org/developers/contributing-code

Done and sorry about that.

[jln (very slow on Chromium), 2015-05-07 19:22:40]

jln@chromium.org changed reviewers:
+ jln@chromium.org

[jln (very slow on Chromium), 2015-05-07 19:22:41]

https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
File
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc
(right):

https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc:67:
ts.tv_sec = ts.tv_nsec = -1;
Style: please break in two expressions.

[noordhuis, 2015-05-07 19:26:09]

On 2015/05/07 19:22:41, jln wrote:
>
https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
> File
> sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc
> (right):
> 
>
https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
>
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc:67:
> ts.tv_sec = ts.tv_nsec = -1;
> Style: please break in two expressions.

I copied that from the code below it.  Should I update that as well?

[jln (very slow on Chromium), 2015-05-07 19:27:07]

On 2015/05/07 19:26:09, noordhuis wrote:
> On 2015/05/07 19:22:41, jln wrote:
> >
>
https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
> > File
> >
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc
> > (right):
> > 
> >
>
https://codereview.chromium.org/1133653002/diff/20001/sandbox/linux/seccomp-b...
> >
>
sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc:67:
> > ts.tv_sec = ts.tv_nsec = -1;
> > Style: please break in two expressions.
> 
> I copied that from the code below it.  Should I update that as well?

Ahh that would be great, thank you!

[noordhuis, 2015-05-07 19:35:30]

Done, PTAL.

[mdempsky, 2015-05-07 19:47:38]

On 2015/05/07 19:35:30, noordhuis wrote:
> Done, PTAL.

LGTM, thanks!

(Also verified that you have a Google CLA on file, as claimed.)

[mdempsky, 2015-05-07 20:06:31]

Looks like CLOCK_{MONOTONIC,REALTIME}_COARSE aren't defined on all of the
buildbots.  We probably need to add

  #if !defined(CLOCK_MONOTONIC_COARSE)
  #define CLOCK_MONOTONIC_COARSE ...
  #endif

guards somewhere. :(

[noordhuis, 2015-05-07 20:16:32]

I've just uploaded a new patch that does just that.  Can you PTAL?

I added the guards in syscall_parameters_restrictions.cc and
syscall_parameters_restrictions_unittests.cc because I wasn't sure if there is a
header file they can share or if it's even desirable to put them in a header
file.

Thanks.

[mdempsky, 2015-05-07 20:23:55]

On 2015/05/07 20:16:32, noordhuis wrote:
> I added the guards in syscall_parameters_restrictions.cc and
> syscall_parameters_restrictions_unittests.cc because I wasn't sure if there is
a
> header file they can share or if it's even desirable to put them in a header
> file.

Hm.  I'd suggest creating a sandbox/linux/system_headers/linux_time.h file and
putting the two defines there to avoid the duplication.

[noordhuis, 2015-05-07 20:38:13]

On 2015/05/07 20:23:55, mdempsky wrote:
> Hm.  I'd suggest creating a sandbox/linux/system_headers/linux_time.h file and
> putting the two defines there to avoid the duplication.

Good call, done.

[mdempsky, 2015-05-07 20:40:36]

LGTM

[noordhuis, 2015-05-11 13:47:34]

This CL seems to have run aground on what appears to be unrelated test failures.
 What do I do now?  Just try to commit it again?

[mdempsky, 2015-05-11 17:14:05]

The CQ bit was checked by mdempsky@chromium.org

[mdempsky, 2015-05-11 17:14:16]

The CQ bit was unchecked by mdempsky@chromium.org

[mdempsky, 2015-05-11 17:14:36]

The CQ bit was checked by mdempsky@chromium.org

[mdempsky, 2015-05-11 17:15:11]

On 2015/05/11 13:47:34, noordhuis wrote:
> This CL seems to have run aground on what appears to be unrelated test
failures.
>  What do I do now?  Just try to commit it again?

Yeah, let's just try CQ'ing it and see what happens.  It looks like
linux_chromium_trusty_rel is just busted.  =/

[commit-bot: I haz the power, 2015-05-11 17:16:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133653002/100001

[commit-bot: I haz the power, 2015-05-11 17:46:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 17:46:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[noordhuis, 2015-05-11 17:54:52]

On 2015/05/11 17:46:17, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

It's checking my corporate email address, ben@strongloop.com, now...  I'm not
sure what changed because AFAICT, all the interaction on this CL has been with
my personal email address.  Should I update the AUTHORS file with both email
addresses?

[mdempsky, 2015-05-11 18:03:35]

On 2015/05/11 17:54:52, noordhuis wrote:
> It's checking my corporate email address, mailto:ben@strongloop.com, now... 
I'm not
> sure what changed because AFAICT, all the interaction on this CL has been with
> my personal email address.

It looks like you have two Rietveld accounts:

  "noordhuis" is info@bnoordhuis.nl
  "bnoordhuis" is ben@strongloop.com

This CL was "created" by bnoordhuis, so chromium_presubmit is looking for
ben@strongloop.com in the AUTHORS file.

> Should I update the AUTHORS file with both email addresses?

There's precedent for multiple entries, but I'd encourage using just one if
possible.  I'm guessing those are your personal and work addresses
(respectively), so I'd suggest picking whichever one reflects whether you're
contributing as an individual or on behalf of your employer.  You can always add
more later if appropriate.

(Of course, if you're contributing this individually, there's the extra
annoyance that you'd need to reupload the CL as "noordhuis" instead.)

[bnoordhuis, 2015-05-19 12:24:34]

Sorry for the delay; between holidays and meetings, this kind of fell by the
wayside.

I've rebased against HEAD and tests still pass in debug and release mode.  Do
you want to give it one more lookover or is it good to CQ?  The only change from
v6 is the entry in the README.

[bnoordhuis, 2015-05-21 15:03:51]

The CQ bit was checked by ben@strongloop.com

[bnoordhuis, 2015-05-21 15:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdempsky@chromium.org
Link to the patchset: https://codereview.chromium.org/1133653002/#ps120001
(title: "Allow coarse clocks in clock_get{res,time} calls, v7")

[commit-bot: I haz the power, 2015-05-21 15:04:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133653002/120001

[commit-bot: I haz the power, 2015-05-21 17:53:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 17:53:53]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[mdempsky, 2015-05-22 21:40:55]

The CQ bit was checked by mdempsky@chromium.org

[commit-bot: I haz the power, 2015-05-22 21:42:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133653002/120001

[commit-bot: I haz the power, 2015-05-22 23:19:59]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-05-22 23:21:47]

Patchset 7 (id:??) landed as
https://crrev.com/7598f464dda3b851eeb77b7d1083d5926a823acf
Cr-Commit-Position: refs/heads/master@{#331201}