Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1130083003: Revert of Use CLOCK_REALTIME_COARSE when available. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use CLOCK_REALTIME_COARSE when available. (patchset #3 id:40001 of https://codereview.chromium.org/1125003002/) Reason for revert: [Sheriff] This causes layout test crashes: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2735 You can add the trybot v8_linux_layout_dbg on reland. Original issue's description: > Use CLOCK_REALTIME_COARSE when available. > > On systems that have CLOCK_REALTIME_COARSE with good enough resolution, we can > avoid making a system call to get the current time; it's serviced from the vDSO. > > BUG= > LOG=N > > Committed: https://crrev.com/537ed7500c087786f28f51ff5222f1c2113776d3 > Cr-Commit-Position: refs/heads/master@{#28280} TBR=jochen@chromium.org,deanm@chromium.org,bmeurer@chromium.org,ben@strongloop.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e137650825fcea22c9e1f1085fc8a3c012f93836 Cr-Commit-Position: refs/heads/master@{#28288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M src/base/platform/time.cc View 2 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Use CLOCK_REALTIME_COARSE when available.
5 years, 7 months ago (2015-05-07 08:51:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130083003/1
5 years, 7 months ago (2015-05-07 08:51:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 08:51:39 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 08:51:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e137650825fcea22c9e1f1085fc8a3c012f93836
Cr-Commit-Position: refs/heads/master@{#28288}

Powered by Google App Engine
This is Rietveld 408576698