Moves management of transients out of Window

Moves management of transients out of Window

And into TransientWindowManager. Additionally moves handling of NULL
layer stacking into TransientStackingWindowClient. The tests that were
exercising these code paths have all been moved to ui/views/corewm.

Also wires up TransientStackingWindowClient in a couple of places that
didn't have it.

The order of removing from transient parent as well as destroying of
transient children is slightly differently than before. To get the
order exactly as it was would require some new specific observer
functions. I'm hoping we don't need those. Hopefully this doesn't
cause issues, if it does I'll revisit.

I ended up exposing convenience functions. That's because typing
something like:

views::corewm::TransientWindowManager::Get(window)->AddTransientChild()

was too much for me. There is also some subtlety in so far as the
Get() function that takes a const Window* may return NULL, where as
non-const never returns NULL.

Lastly I had to make Window friend TransientWindowManager. This is
temporary until I create a specific TransientWindowManagerObserver
that contains the two transient related observer functions in
WindowObserver.

BUG=none
TEST=none
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243368

[Ben Goodger (Google), 2013-12-18 00:32:37]

https://codereview.chromium.org/115453004/diff/120001/ui/aura/window.h
File ui/aura/window.h (right):

https://codereview.chromium.org/115453004/diff/120001/ui/aura/window.h#newcod...
ui/aura/window.h:377: friend class views::corewm::TransientWindowManager;
What's this used for?

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
File ui/views/corewm/transient_window_manager.h (right):

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
ui/views/corewm/transient_window_manager.h:19: VIEWS_EXPORT aura::Window*
GetTransientParent(aura::Window* window);
maybe move these functions to window_util.cc/h in the same dir instead of making
everyone include transient window manager?

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
ui/views/corewm/transient_window_manager.h:41: class VIEWS_EXPORT
TransientWindowManager : public aura::WindowObserver {
soft preference for this to be TransientWindowController to match the other
classes in this dir, unless you think we should rename those (which I'm open to
pursuing at some point in the future).

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
ui/views/corewm/transient_window_manager.h:71: // WindowObserver:
private

[sky, 2014-01-06 18:42:47]

https://codereview.chromium.org/115453004/diff/120001/ui/aura/window.h
File ui/aura/window.h (right):

https://codereview.chromium.org/115453004/diff/120001/ui/aura/window.h#newcod...
ui/aura/window.h:377: friend class views::corewm::TransientWindowManager;
On 2013/12/18 00:32:38, Ben Goodger (Google) wrote:
> What's this used for? 

WindowObserver has two methods related to transients: OnAddTransientChild and
OnRemoveTransientChild. In hopes of keeping this patch from spawling too much I
left those methods in WindowObserver. Since TransientWindowManager handles all
the transient logic now it has to be the place to notify the observers, hence
the friend. It's temporary though. After I land this I'll make
TransientWindowManager (or TransientWindowController) support an observer,
remove the two methods from WindowObserver and remove this friend.

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
File ui/views/corewm/transient_window_manager.h (right):

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
ui/views/corewm/transient_window_manager.h:19: VIEWS_EXPORT aura::Window*
GetTransientParent(aura::Window* window);
On 2013/12/18 00:32:38, Ben Goodger (Google) wrote:
> maybe move these functions to window_util.cc/h in the same dir instead of
making
> everyone include transient window manager?

Done.

https://codereview.chromium.org/115453004/diff/120001/ui/views/corewm/transie...
ui/views/corewm/transient_window_manager.h:41: class VIEWS_EXPORT
TransientWindowManager : public aura::WindowObserver {
On 2013/12/18 00:32:38, Ben Goodger (Google) wrote:
> soft preference for this to be TransientWindowController to match the other
> classes in this dir, unless you think we should rename those (which I'm open
to
> pursuing at some point in the future).

I ended up needing aura/client/transient_window_client and an implementation of
TransientWindowClient in TransientWindowController. This meant I left this class
as TransientWindowManager.

TransientWindowClient is a trivial interface. The implementation,
TransientWindowController, redirects to TransientWindowManager which has the per
window state. Doing this allows for lazily creating the TransientWindowManager.
Another option is to explicitly set a TransientWindowManager on every window
during creation. This felt heavyweight, but is certainly possible by making
WMState an EnvObserver and having WMState::OnWindowInitialized() set a
TransientWindowClient per window. Going this route would mean there is no need
for what is currently TransientWindowController and this could be renamed to
TransientWindowController. Let me know if you prefer that route.

[Ben Goodger (Google), 2014-01-06 20:44:34]

nah what you have is fine. lgtm.

[commit-bot: I haz the power, 2014-01-06 20:51:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/115453004/420001

[commit-bot: I haz the power, 2014-01-07 01:11:34]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-07 17:04:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/115453004/500002

[commit-bot: I haz the power, 2014-01-07 19:53:01]

Change committed as 243368