Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update all callsites of the TryCatch ctor to pass an Isolate BUG=4134 R=vogelheim@chromium.org LOG=n Committed: https://crrev.com/5df3b4ab5cd4bfafd0ac758867b1395c787f84a3 Cr-Commit-Position: refs/heads/master@{#28678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -162 lines) Patch
M samples/process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M src/d8.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/d8-debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-observe.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/function-tester.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 107 chunks +115 lines, -113 lines 0 comments Download
M test/cctest/test-debug.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-decls.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 6 months ago (2015-05-28 12:17:07 UTC) #1
vogelheim
lgtm
5 years, 6 months ago (2015-05-28 12:32:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154423004/1
5 years, 6 months ago (2015-05-28 12:33:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 12:49:37 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 12:49:48 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5df3b4ab5cd4bfafd0ac758867b1395c787f84a3
Cr-Commit-Position: refs/heads/master@{#28678}

Powered by Google App Engine
This is Rietveld 408576698