src/runtime/runtime-observe.cc - Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-observe.cc

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-observe.cc

diff --git a/src/runtime/runtime-observe.cc b/src/runtime/runtime-observe.cc

index c03e31effcd0e716552c07fb3db7f4a0671d80c9..8fc201da0e66626169d5926aec80a6afb27efed3 100644

--- a/src/runtime/runtime-observe.cc

+++ b/src/runtime/runtime-observe.cc

@@ -58,7 +58,7 @@ RUNTIME_FUNCTION(Runtime_DeliverObservationChangeRecords) {

DCHECK(args.length() == 2);

CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 0);

CONVERT_ARG_HANDLE_CHECKED(Object, argument, 1);

- v8::TryCatch catcher;

+ v8::TryCatch catcher(reinterpret_cast<v8::Isolate*>(isolate));

// We should send a message on uncaught exception thrown during

// Object.observe delivery while not interrupting further delivery, thus

// we make a call inside a verbose TryCatch.

« no previous file with comments | « src/messages.cc ('k') | test/cctest/compiler/function-tester.h » ('j') | no next file with comments »