samples/shell.cc - Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/shell.cc

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/shell.cc

diff --git a/samples/shell.cc b/samples/shell.cc

index 48c042c7956d1a931926d9cfdbd6a0b17a71ba13..c537fa539cf1c38fc0237d5be1d5483f89386c73 100644

--- a/samples/shell.cc

+++ b/samples/shell.cc

@@ -325,7 +325,7 @@ bool ExecuteString(v8::Isolate* isolate,

bool print_result,

bool report_exceptions) {

v8::HandleScope handle_scope(isolate);

- v8::TryCatch try_catch;

+ v8::TryCatch try_catch(isolate);

v8::ScriptOrigin origin(name);

v8::Handle<v8::Script> script = v8::Script::Compile(source, &origin);

if (script.IsEmpty()) {

« no previous file with comments | « samples/process.cc ('k') | src/api.cc » ('j') | no next file with comments »