test/cctest/test-accessors.cc - Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-accessors.cc

Issue 1154423004: Update all callsites of the TryCatch ctor to pass an Isolate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-accessors.cc

diff --git a/test/cctest/test-accessors.cc b/test/cctest/test-accessors.cc

index ac631757b2863c4b5ab4b91b5026086a0b75b1de..14303e2371c58684d937f420a64db55c222db42a 100644

--- a/test/cctest/test-accessors.cc

+++ b/test/cctest/test-accessors.cc

@@ -552,7 +552,7 @@ THREADED_TEST(AccessorPropertyCrossContext) {

v8::Handle<v8::Function> fun = v8::Function::New(isolate, check_contexts);

LocalContext switch_context;

switch_context->Global()->Set(v8_str("fun"), fun);

- v8::TryCatch try_catch;

+ v8::TryCatch try_catch(isolate);

expected_current_context = env.local();

expected_calling_context = switch_context.local();

CompileRun(

« no previous file with comments | « test/cctest/compiler/function-tester.h ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »