Make gclient warn when svn is used.

Make gclient warn when svn is used.

Include links to the tracking bug and to request creating git repositories. Also
include note how to keep subversion support, if users require this.

It won't warn when git-svn clones are used.

There is no functional change except printing a warning to stderr.

Remove stale code. The CHROMIUM_SRC_URL variable is also defined in gclient.py
so it looks like a copy-paste error.

R=iannucci@chromium.org
BUG=475320
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295478

[iannucci, 2015-05-26 21:35:54]

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py#newcode1168
gclient_scm.py:1168: 'Oh hai! You are using subversion. Chrome infra is eager
love to get rid',
s/love//

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py#newcode1181
gclient_scm.py:1181: if SVNWrapper._USED:
won't this be always-False?

I think you want `if not SVNWrapper._USED:`

lets rename it to _PRINTED_DEPRECATION too

[M-A Ruel, 2015-05-27 00:50:00]

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py#newcode1168
gclient_scm.py:1168: 'Oh hai! You are using subversion. Chrome infra is eager
love to get rid',
On 2015/05/26 21:35:54, iannucci wrote:
> s/love//

Done.

https://codereview.chromium.org/1154173003/diff/1/gclient_scm.py#newcode1181
gclient_scm.py:1181: if SVNWrapper._USED:
On 2015/05/26 21:35:54, iannucci wrote:
> won't this be always-False?
> 
> I think you want `if not SVNWrapper._USED:`
> 
> lets rename it to _PRINTED_DEPRECATION too

Done.

[M-A Ruel, 2015-05-29 01:25:23]

Ping

[iannucci, 2015-05-29 01:32:51]

thought I clicked lgtm on this already :(

[M-A Ruel, 2015-06-01 18:47:22]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-06-01 18:47:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154173003/20001

[commit-bot: I haz the power, 2015-06-01 18:50:59]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295478

[Sergiy Byelozyorov, 2015-06-02 09:01:18]

sergiyb@chromium.org changed reviewers:
+ sergiyb@chromium.org

[Sergiy Byelozyorov, 2015-06-02 09:01:18]

I disagree with the message. It should not suggest developers to disable updates
on depot_tools. This will, for example, prevent me from re-landing
https://codereview.chromium.org/1152823005/, which depends on having all users
up-to-date depot_tools. The fact that a user uses an SVN checkout doesn't mean
that this is their choice and having out-of-date depot_tools would prevent them
from working with other Git-based repositories that depend on having up-to-date
depot_tools, e.g. Chromium.

I've removed part of the message and added a mechanism to suppress the notice
via env variable in https://codereview.chromium.org/1162153004.