Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 1162153004: Add env variable to suppress the notice about deprecated SVN (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel, Adrian Kuegel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add env variable to suppress the notice about deprecated SVN Also removed part of the message that encourages users to disable updates to depot_tools. If the users do not enable updates, it prevents landing changes into project repositories that depend on having latest version of the depot_tools, e.g. https://codereview.chromium.org/1152823005/. R=akuegel@chromium.org TBR=maruel@chromium.org, iannucci@chromium.org BUG=475320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295486

Patch Set 1 #

Patch Set 2 : Fix spelling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M gclient_scm.py View 1 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-02 09:01:53 UTC) #1
Adrian Kuegel
lgtm
5 years, 6 months ago (2015-06-02 09:33:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162153004/20001
5 years, 6 months ago (2015-06-02 09:33:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=295486
5 years, 6 months ago (2015-06-02 09:36:46 UTC) #5
M-A Ruel
I'm more interesting in where did you see this message happening and why you see ...
5 years, 6 months ago (2015-06-03 10:00:56 UTC) #6
Adrian Kuegel
On 2015/06/03 10:00:56, M-A Ruel wrote: > I'm more interesting in where did you see ...
5 years, 6 months ago (2015-06-03 10:03:03 UTC) #7
M-A Ruel
On 2015/06/03 10:03:03, Adrian Kuegel wrote: > On 2015/06/03 10:00:56, M-A Ruel wrote: > > ...
5 years, 6 months ago (2015-06-03 10:06:32 UTC) #8
Adrian Kuegel
On 2015/06/03 10:06:32, M-A Ruel wrote: > On 2015/06/03 10:03:03, Adrian Kuegel wrote: > > ...
5 years, 6 months ago (2015-06-03 10:13:53 UTC) #9
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-03 10:46:59 UTC) #10
Message was sent while issue was closed.
On 2015/06/03 10:13:53, Adrian Kuegel wrote:
> On 2015/06/03 10:06:32, M-A Ruel wrote:
> > On 2015/06/03 10:03:03, Adrian Kuegel wrote:
> > > On 2015/06/03 10:00:56, M-A Ruel wrote:
> > > > I'm more interesting in where did you see this message happening and why
> you
> > > see
> > > > the need to shut it off at all.
> > > > 
> > > > I don't think this patch is a good idea to be honest.
> > > 
> > > The message was shown when running auto_deploy.py for CQ (which itself
runs
> > > gclient sync). This leads to alerts being send which are not actionable.
> > 
> > Why not stop using svn in the tree that the CQ checks out instead?
> > 
> > https://code.google.com/p/chromium/issues/detail?id=475320 is real, I am
going
> > to break you.
> 
> We still have CQs for svn repos (tools and chromium_deps). I have already
filed
> a fixit bug to move chromium_deps to git, and for tools I am splitting it into
> depot_tools and build, but we are not there yet. So this was meant as a quick
> fix to get rid of the alerts.

We can either do that or add support for Git mirrors and git-cl-dcommit to CQ.
There are other many SVN repos that still have: build, build_internal and
depot_tools, chromium_deps, chrome_golo, blink. IMHO, we won't be able to fix
them all in a fixit.

Powered by Google App Engine
This is Rietveld 408576698