Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: gclient_scm.py

Issue 1154173003: Make gclient warn when svn is used. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Fixed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index 8115dc8d73d87552c915c5e3245db2c3eaff2700..55a73f4f82013271f140c87a0a381691d5801a26 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -29,7 +29,7 @@ THIS_FILE_PATH = os.path.abspath(__file__)
GSUTIL_DEFAULT_PATH = os.path.join(
os.path.dirname(os.path.abspath(__file__)), 'gsutil.py')
-CHROMIUM_SRC_URL = 'https://chromium.googlesource.com/chromium/src.git'
+
class DiffFiltererWrapper(object):
"""Simple base class which tracks which file is being diffed and
replaces instances of its file name in the original and
@@ -830,12 +830,6 @@ class GitWrapper(SCMWrapper):
'print_func': self.filter,
'refs': []
}
- # TODO(hinoka): This currently just fails because lkcr/lkgr are branches
- # not tags. This also adds 20 seconds to every bot_update
- # run, so I'm commenting this out until lkcr/lkgr become
- # tags. (2014/4/24)
- # if url == CHROMIUM_SRC_URL or url + '.git' == CHROMIUM_SRC_URL:
- # mirror_kwargs['refs'].extend(['refs/tags/lkgr', 'refs/tags/lkcr'])
if hasattr(options, 'with_branch_heads') and options.with_branch_heads:
mirror_kwargs['refs'].append('refs/branch-heads/*')
if hasattr(options, 'with_tags') and options.with_tags:
@@ -1168,6 +1162,25 @@ class GitWrapper(SCMWrapper):
class SVNWrapper(SCMWrapper):
""" Wrapper for SVN """
name = 'svn'
+ _PRINTED_DEPRECATION = False
+
+ _MESSAGE = (
+ 'Oh hai! You are using subversion. Chrome infra is eager to get rid of',
+ 'svn support so please switch to git.',
+ 'Tracking bug: http://crbug.com/475320',
+ 'Request a new git repository at: ',
+ ' https://code.google.com/p/chromium/issues/entry?template=Infra-Git',
+ '',
+ 'If subversion support is needed, pin your depot_tools to ',
+ 'c20f470011e2ea4d81527976f3bded2c13e258af and set the env var',
+ 'DEPOT_TOOLS_UPDATE=0',
+ 'Thank you for your business!')
+
+ def __init__(self, *args, **kwargs):
+ super(SVNWrapper, self).__init__(*args, **kwargs)
+ if not SVNWrapper._PRINTED_DEPRECATION:
+ SVNWrapper._PRINTED_DEPRECATION = True
+ sys.stderr.write('\n'.join(self._MESSAGE) + '\n')
@staticmethod
def BinaryExists():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698