Make gclient warn when svn is used.

gclient_scm.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 from __future__ import print_function
 
 import errno
 import logging
@@ skipping 11 matching lines @@
 import scm
 import shutil
 import subprocess2
 
 
 THIS_FILE_PATH = os.path.abspath(__file__)
 
 GSUTIL_DEFAULT_PATH = os.path.join(
     os.path.dirname(os.path.abspath(__file__)), 'gsutil.py')
 
-CHROMIUM_SRC_URL = 'https://chromium.googlesource.com/chromium/src.git'
+
 class DiffFiltererWrapper(object):
   """Simple base class which tracks which file is being diffed and
   replaces instances of its file name in the original and
   working copy lines of the svn/git diff output."""
   index_string = None
   original_prefix = "--- "
   working_prefix = "+++ "
 
   def __init__(self, relpath, print_func):
     # Note that we always use '/' as the path separator to be
@@ skipping 780 matching lines @@
                         'old_' + self.relpath.replace(os.sep, '_')) + '.git'
 
   def _GetMirror(self, url, options):
     """Get a git_cache.Mirror object for the argument url."""
     if not git_cache.Mirror.GetCachePath():
       return None
     mirror_kwargs = {
         'print_func': self.filter,
         'refs': []
     }
-    # TODO(hinoka): This currently just fails because lkcr/lkgr are branches
-    #               not tags. This also adds 20 seconds to every bot_update
-    #               run, so I'm commenting this out until lkcr/lkgr become
-    #               tags.  (2014/4/24)
-    # if url == CHROMIUM_SRC_URL or url + '.git' == CHROMIUM_SRC_URL:
-    #  mirror_kwargs['refs'].extend(['refs/tags/lkgr', 'refs/tags/lkcr'])
     if hasattr(options, 'with_branch_heads') and options.with_branch_heads:
       mirror_kwargs['refs'].append('refs/branch-heads/*')
     if hasattr(options, 'with_tags') and options.with_tags:
       mirror_kwargs['refs'].append('refs/tags/*')
     return git_cache.Mirror(url, **mirror_kwargs)
 
   @staticmethod
   def _UpdateMirror(mirror, options):
     """Update a git mirror by fetching the latest commits from the remote."""
     if getattr(options, 'shallow', False):
@@ skipping 312 matching lines @@
     cmd = ['git'] + args
     if show_header:
       gclient_utils.CheckCallAndFilterAndHeader(cmd, env=env, **kwargs)
     else:
       gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
 
 
 class SVNWrapper(SCMWrapper):
   """ Wrapper for SVN """
   name = 'svn'
+  _USED = False
+
+  _MESSAGE = (
+    'Oh hai! You are using subversion. Chrome infra is eager love to get rid',

[iannucci, 2015/05/26 21:35:54]

s/love//

[M-A Ruel, 2015/05/27 00:50:00]

Done.

+    'of svn support so please switch to git.',
+    'Tracking bug: http://crbug.com/475320',
+    'Request a new git repository at: ',
+    '  https://code.google.com/p/chromium/issues/entry?template=Infra-Git',
+    '',
+    'If subversion support is needed, pin your depot_tools to ',
+    'c20f470011e2ea4d81527976f3bded2c13e258af and set the env var',
+    'DEPOT_TOOLS_UPDATE=0',
+    'Thank you for your business!')
+
+  def __init__(self, *args, **kwargs):
+    super(SVNWrapper, self).__init__(*args, **kwargs)
+    if SVNWrapper._USED:

[iannucci, 2015/05/26 21:35:54]

won't this be always-False?

I think you want `if not SVNWrapper._USED:`

lets rename it to _PRINTED_DEPRECATION too

[M-A Ruel, 2015/05/27 00:50:00]

Done.

+      SVNWrapper._USED = True
+      sys.stderr.write('\n'.join(self._MESSAGE) + '\n')
 
   @staticmethod
   def BinaryExists():
     """Returns true if the command exists."""
     try:
       result, version = scm.SVN.AssertVersion('1.4')
       if not result:
         raise gclient_utils.Error('SVN version is older than 1.4: %s' % version)
       return result
     except OSError:
@@ skipping 446 matching lines @@
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'theirs-conflict'))
     elif options.manually_grab_svn_rev:
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'postpone'))
     elif command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
       new_command.extend(('--accept', 'postpone'))
     return new_command