Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 6 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, jam
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests. This change removes the legacy hooks for running scripts like 'gn check' on the GN bots; now what we run is purely driven by the //testing/buildbot/*.json files in the Chromium repo. I think this is the last major discrepancy between the chromium_gn recipe and the chromium and chromium_trybot recipes, so the next step is to start flipping some of the GN bots over to the chromium and chromium_trybot recipes (which will require master restarts). R=phajdan.jr@chromium.org BUG=481693 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295535

Patch Set 1 #

Patch Set 2 : add comment explaining the lack of android tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+907 lines, -418 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +0 lines, -14 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.py View 1 7 chunks +14 lines, -15 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_chromiumos_Linux_ChromiumOS_GN__dbg_.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN.json View 2 chunks +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Android_GN__dbg_.json View 2 chunks +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN_Clobber.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_linux_Linux_GN__dbg_.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webkit_Linux_GN.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webkit_Linux_GN__dbg_.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Android_GN.json View 2 chunks +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Android_GN__dbg_.json View 2 chunks +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Linux_GN.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Linux_GN__dbg_.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Mac_GN.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Mac_GN__dbg_.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Win_GN.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_webrtc_fyi_Win_GN__dbg_.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_win_Win8_GN.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_win_Win8_GN__dbg_.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_win_Win_x64_GN.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_chromium_win_Win_x64_GN__dbg_.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json View 2 chunks +1 line, -16 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Linux_GN.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_blink_linux_chromium_gn_rel.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_linux_android_chromium_gn_compile_dbg.json View 2 chunks +8 lines, -57 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_linux_android_chromium_gn_compile_rel.json View 2 chunks +8 lines, -45 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_linux_linux_chromium_gn_chromeos_dbg.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_linux_linux_chromium_gn_chromeos_rel.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_linux_linux_chromium_gn_dbg.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_dbg.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json View 1 chunk +21 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_dbg.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win8_chromium_gn_rel.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win_chromium_gn_x64_dbg.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_win_win_chromium_gn_x64_rel.json View 1 chunk +43 lines, -5 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_v8_v8_android_chromium_gn_dbg.json View 2 chunks +8 lines, -57 lines 0 comments Download
M scripts/slave/recipes/chromium_gn.expected/full_tryserver_v8_v8_linux_chromium_gn_rel.json View 1 chunk +22 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-04 17:10:38 UTC) #1
jam
lgtm
5 years, 6 months ago (2015-06-04 17:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153933004/20001
5 years, 6 months ago (2015-06-04 21:04:38 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 21:09:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295535

Powered by Google App Engine
This is Rietveld 408576698