scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json - Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json

Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: add comment explaining the lack of android tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN.json ('k') | scripts/slave/recipes/chromium_gn.expected/full_chromium_webkit_Linux_GN.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json

diff --git a/scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json b/scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json

index 78b75269a8d726e7f5dcdd179670a04eed3cb79b..5e2b55010b78c975ae250084cf1ce3b064c6a915 100644

--- a/scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json

+++ b/scripts/slave/recipes/chromium_gn.expected/full_chromium_mac_Mac_GN__dbg_.json

@@ -182,15 +182,31 @@

"name": "compile"

{

+ "allow_subannotations": true,

"cmd": [

"python",

"-u",

- "[DEPOT_TOOLS]/gn.py",

- "--root=[SLAVE_BUILD]/src",

- "check",

- "//out/Debug"

+ "[BUILD]/scripts/slave/runtest.py",

+ "--target",

+ "Debug",

+ "--factory-properties",

+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"buildername\": \"Mac GN (dbg)\", \"buildnumber\": 571, \"mastername\": \"chromium.mac\", \"recipe\": \"chromium_gn\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",

+ "--build-properties",

+ "--annotate=gtest",

+ "--test-type=base_unittests",

+ "--step-name=base_unittests",

+ "--test-launcher-summary-output",

+ "/path/to/tmp/json",

+ "--generate-json-file",

+ "-o",

+ "gtest-results/base_unittests",

+ "--builder-name=Mac GN (dbg)",

+ "--slave-name=TestSlavename",

+ "--build-number=571",

+ "base_unittests"

"cwd": "[SLAVE_BUILD]",

- "name": "gn check"

+ "name": "base_unittests"

}

]