scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json - Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json

Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: add comment explaining the lack of android tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_gn.expected/full_chromium_win_Win_x64_GN__dbg_.json ('k') | scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Linux_GN.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json

diff --git a/scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json b/scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json

index 1b3d12156384a4e5ee16a7e159ab26b376696d19..02de30174ae5b45628c2b914dce5927d6284dd58 100644

--- a/scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json

+++ b/scripts/slave/recipes/chromium_gn.expected/full_client_v8_fyi_V8_Android_GN__dbg_.json

@@ -111,9 +111,7 @@

"@@@STEP_TEXT@path: [SLAVE_BUILD]/src/testing/buildbot/client.v8.fyi.json@@@",

"@@@STEP_LOG_LINE@json.output@{@@@",

"@@@STEP_LOG_LINE@json.output@ \"V8 Android GN (dbg)\": {@@@",

- "@@@STEP_LOG_LINE@json.output@ \"gtest_tests\": [@@@",

- "@@@STEP_LOG_LINE@json.output@ \"base_unittests\"@@@",

- "@@@STEP_LOG_LINE@json.output@ ]@@@",

+ "@@@STEP_LOG_LINE@json.output@ \"gtest_tests\": []@@@",

"@@@STEP_LOG_LINE@json.output@ }@@@",

"@@@STEP_LOG_LINE@json.output@}@@@",

"@@@STEP_LOG_END@json.output@@@"

@@ -157,22 +155,9 @@

"--goma-dir",

"[BUILD]/goma",

"--",

- "base_unittests_apk",

"chrome_shell_apk"

"cwd": "[SLAVE_BUILD]",

"name": "compile"

- },

- {

- "cmd": [

- "python",

- "-u",

- "[DEPOT_TOOLS]/gn.py",

- "--root=[SLAVE_BUILD]/src",

- "check",

- "//out/Debug"

- ],

- "cwd": "[SLAVE_BUILD]",

- "name": "gn check"

}

]