Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json

Issue 1153933004: Flip GN bots to be purely driven by //testing/buildbot/*.json files for tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: add comment explaining the lack of android tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
diff --git a/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json b/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
index e21fc9b55d4a36cc0ac2052d7fd739f801a5bce1..964a96c518a5545f05862af1a1afbad7bfcc7e57 100644
--- a/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
+++ b/scripts/slave/recipes/chromium_gn.expected/full_tryserver_chromium_mac_mac_chromium_gn_rel.json
@@ -278,15 +278,31 @@
"name": "compile"
},
{
+ "allow_subannotations": true,
"cmd": [
"python",
"-u",
- "[DEPOT_TOOLS]/gn.py",
- "--root=[SLAVE_BUILD]/src",
- "check",
- "//out/Release"
+ "[BUILD]/scripts/slave/runtest.py",
+ "--target",
+ "Release",
+ "--factory-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"mac_chromium_gn_rel\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.mac\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_gn\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--build-properties",
+ "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \"branch\": \"\", \"buildername\": \"mac_chromium_gn_rel\", \"buildnumber\": 571, \"issue\": 12853011, \"mastername\": \"tryserver.chromium.mac\", \"patch_project\": \"chromium\", \"patchset\": 1, \"project\": \"chrome\", \"recipe\": \"chromium_gn\", \"repository\": \"\", \"requester\": \"commit-bot@chromium.org\", \"revision\": \"HEAD\", \"rietveld\": \"https://codereview.chromium.org\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestSlavename\"}",
+ "--annotate=gtest",
+ "--test-type=base_unittests",
+ "--step-name=base_unittests (with patch)",
+ "--test-launcher-summary-output",
+ "/path/to/tmp/json",
+ "--generate-json-file",
+ "-o",
+ "gtest-results/base_unittests",
+ "--builder-name=mac_chromium_gn_rel",
+ "--slave-name=TestSlavename",
+ "--build-number=571",
+ "base_unittests"
],
"cwd": "[SLAVE_BUILD]",
- "name": "gn check"
+ "name": "base_unittests (with patch)"
}
]

Powered by Google App Engine
This is Rietveld 408576698