Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153593003: Remove the SkCanvas comment API (Closed)

Created:
5 years, 7 months ago by f(malita)
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : SkDumpCanvas enums #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -288 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M experimental/PdfViewer/SkNulCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gm/rects.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 2 chunks +0 lines, -36 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/core/SkRecords.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 2 chunks +0 lines, -16 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.h View 3 chunks +0 lines, -38 lines 0 comments Download
M src/utils/debugger/SkDrawCommand.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
f(malita)
https://codereview.chromium.org/1151933002/ needs to land/roll first, but otherwise good to go.
5 years, 7 months ago (2015-05-21 19:04:52 UTC) #1
reed1
lgtm
5 years, 7 months ago (2015-05-21 19:05:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153593003/40001
5 years, 6 months ago (2015-06-15 16:35:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 16:40:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153593003/40001
5 years, 6 months ago (2015-06-15 20:14:48 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 20:15:34 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/109a23d64ff9cf210e6b0aa8940b4fcea3f05a97

Powered by Google App Engine
This is Rietveld 408576698