Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 1153593003: Remove the SkCanvas comment API (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPictureFlat.h ('k') | src/core/SkPictureRecord.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPicturePlayback.cpp
diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp
index 4f775cf9fd93305cd94adf1f9172aed90f516d4f..f4fdc8b83ade5926e2bfa8f9051d5ae4414d6a07 100644
--- a/src/core/SkPicturePlayback.cpp
+++ b/src/core/SkPicturePlayback.cpp
@@ -204,18 +204,18 @@ void SkPicturePlayback::handleOp(SkReader32* reader,
reader->readRRect(&inner);
canvas->drawDRRect(outer, inner, paint);
} break;
- case BEGIN_COMMENT_GROUP: {
- const char* desc = reader->readString();
- canvas->beginCommentGroup(desc);
- } break;
- case COMMENT: {
- const char* kywd = reader->readString();
- const char* value = reader->readString();
- canvas->addComment(kywd, value);
- } break;
- case END_COMMENT_GROUP: {
- canvas->endCommentGroup();
- } break;
+ case BEGIN_COMMENT_GROUP:
+ reader->readString();
+ // deprecated (M44)
+ break;
+ case COMMENT:
+ reader->readString();
+ reader->readString();
+ // deprecated (M44)
+ break;
+ case END_COMMENT_GROUP:
+ // deprecated (M44)
+ break;
case DRAW_OVAL: {
const SkPaint& paint = *fPictureData->getPaint(reader);
canvas->drawOval(reader->skipT<SkRect>(), paint);
« no previous file with comments | « src/core/SkPictureFlat.h ('k') | src/core/SkPictureRecord.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698