Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: src/core/SkPictureRecord.cpp

Issue 1153593003: Remove the SkCanvas comment API (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPictureRecord.h ('k') | src/core/SkRecordDraw.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkPictureRecord.cpp
diff --git a/src/core/SkPictureRecord.cpp b/src/core/SkPictureRecord.cpp
index 07811fb1280513e597669f71c2de7b66ad2370ed..c85af901c6472b426b69f6a5b4c6f1620d24b09d 100644
--- a/src/core/SkPictureRecord.cpp
+++ b/src/core/SkPictureRecord.cpp
@@ -815,33 +815,6 @@ void SkPictureRecord::onDrawPatch(const SkPoint cubics[12], const SkColor colors
this->validate(initialOffset, size);
}
-void SkPictureRecord::beginCommentGroup(const char* description) {
- // op/size + length of string + \0 terminated chars
- size_t length = strlen(description);
- size_t size = 2 * kUInt32Size + SkAlign4(length + 1);
- size_t initialOffset = this->addDraw(BEGIN_COMMENT_GROUP, &size);
- fWriter.writeString(description, length);
- this->validate(initialOffset, size);
-}
-
-void SkPictureRecord::addComment(const char* kywd, const char* value) {
- // op/size + 2x length of string + 2x \0 terminated chars
- size_t kywdLen = strlen(kywd);
- size_t valueLen = strlen(value);
- size_t size = 3 * kUInt32Size + SkAlign4(kywdLen + 1) + SkAlign4(valueLen + 1);
- size_t initialOffset = this->addDraw(COMMENT, &size);
- fWriter.writeString(kywd, kywdLen);
- fWriter.writeString(value, valueLen);
- this->validate(initialOffset, size);
-}
-
-void SkPictureRecord::endCommentGroup() {
- // op/size
- size_t size = 1 * kUInt32Size;
- size_t initialOffset = this->addDraw(END_COMMENT_GROUP, &size);
- this->validate(initialOffset, size);
-}
-
///////////////////////////////////////////////////////////////////////////////
SkSurface* SkPictureRecord::onNewSurface(const SkImageInfo& info, const SkSurfaceProps&) {
« no previous file with comments | « src/core/SkPictureRecord.h ('k') | src/core/SkRecordDraw.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698