Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: include/core/SkCanvas.h

Issue 1153593003: Remove the SkCanvas comment API (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: rebased Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rects.cpp ('k') | include/core/SkPicture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkCanvas.h
diff --git a/include/core/SkCanvas.h b/include/core/SkCanvas.h
index 8a71f1d0bbe9827f6eeae21aee322e59c8e65808..cfeaa5f1d14c746247c9880784746a69e78440ac 100644
--- a/include/core/SkCanvas.h
+++ b/include/core/SkCanvas.h
@@ -1033,20 +1033,6 @@ public:
*/
void drawDrawable(SkDrawable* drawable);
- /** Add comments. beginCommentGroup/endCommentGroup open/close a new group.
- Each comment added via addComment is notionally attached to its
- enclosing group. Top-level comments simply belong to no group.
- */
- virtual void beginCommentGroup(const char* /*description*/) {
- // do nothing. Subclasses may do something
- }
- virtual void addComment(const char* /*kywd*/, const char* /*value*/) {
- // do nothing. Subclasses may do something
- }
- virtual void endCommentGroup() {
- // do nothing. Subclasses may do something
- }
-
//////////////////////////////////////////////////////////////////////////
/** Get the current filter object. The filter's reference count is not
@@ -1425,28 +1411,6 @@ private:
};
#define SkAutoCanvasRestore(...) SK_REQUIRE_LOCAL_VAR(SkAutoCanvasRestore)
-/** Stack helper class to automatically open and close a comment block
- */
-class SkAutoCommentBlock : SkNoncopyable {
-public:
- SkAutoCommentBlock(SkCanvas* canvas, const char* description) {
- fCanvas = canvas;
- if (fCanvas) {
- fCanvas->beginCommentGroup(description);
- }
- }
-
- ~SkAutoCommentBlock() {
- if (fCanvas) {
- fCanvas->endCommentGroup();
- }
- }
-
-private:
- SkCanvas* fCanvas;
-};
-#define SkAutoCommentBlock(...) SK_REQUIRE_LOCAL_VAR(SkAutoCommentBlock)
-
/**
* If the caller wants read-only access to the pixels in a canvas, it can just
* call canvas->peekPixels(), since that is the fastest way to "peek" at the
« no previous file with comments | « gm/rects.cpp ('k') | include/core/SkPicture.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698