Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151603005: Revert of Store context options on caps. (Closed)

Created:
5 years, 7 months ago by bsalomon
Modified:
5 years, 7 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@onecaps
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Store context options on caps. (patchset #3 id:40001 of https://codereview.chromium.org/1158433006/) Reason for revert: breaking chromeos build (???) Original issue's description: > Store context options on caps. > > Committed: https://skia.googlesource.com/skia/+/f28cff71db2cbb1ff18a8fbf1e80ca761d1f69bc TBR=joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/08bf86d1b7b03cc6829f2488d9adcb0502e84b97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -128 lines) Patch
M bench/nanobench.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrCaps.h View 4 chunks +1 line, -11 lines 0 comments Download
M include/gpu/GrContext.h View 5 chunks +21 lines, -5 lines 0 comments Download
D include/gpu/GrContextOptions.h View 1 chunk +0 lines, -24 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +12 lines, -14 lines 0 comments Download
M src/gpu/GrContextFactory.h View 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuFactory.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrGpuFactory.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLContext.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 3 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/CopyTilesRenderer.h View 2 chunks +1 line, -2 lines 0 comments Download
M tools/CopyTilesRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.h View 9 chunks +8 lines, -9 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderingFlags.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Created Revert of Store context options on caps.
5 years, 7 months ago (2015-05-22 19:40:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151603005/1
5 years, 7 months ago (2015-05-22 19:40:46 UTC) #2
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 19:41:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/08bf86d1b7b03cc6829f2488d9adcb0502e84b97

Powered by Google App Engine
This is Rietveld 408576698