Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1150093003: Move GLES2, GPU & Surfaces into the ViewManager directory. This does not merge the applications, th… (Closed)

Created:
5 years, 7 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GLES2, GPU & Surfaces into the ViewManager directory. This does not merge the applications, that will be a subsequent step. R=sky@chromium.org BUG= Committed: https://crrev.com/4b12854e86fcaeef3531f8955c6e4d0e1b7a3036 Cr-Commit-Position: refs/heads/master@{#331039}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -2962 lines) Patch
D components/gles2/BUILD.gn View 1 1 chunk +0 lines, -60 lines 0 comments Download
D components/gles2/DEPS View 1 chunk +0 lines, -7 lines 0 comments Download
D components/gles2/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/gles2/command_buffer_driver.h View 1 chunk +0 lines, -117 lines 0 comments Download
D components/gles2/command_buffer_driver.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D components/gles2/command_buffer_impl.h View 1 1 chunk +0 lines, -77 lines 0 comments Download
D components/gles2/command_buffer_impl.cc View 1 1 chunk +0 lines, -164 lines 0 comments Download
D components/gles2/command_buffer_impl_observer.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
D components/gles2/command_buffer_type_conversions.h View 1 chunk +0 lines, -67 lines 0 comments Download
D components/gles2/command_buffer_type_conversions.cc View 1 chunk +0 lines, -170 lines 0 comments Download
D components/gles2/gpu_impl.h View 1 chunk +0 lines, -49 lines 0 comments Download
D components/gles2/gpu_impl.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D components/gles2/gpu_state.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/gles2/gpu_state.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D components/gles2/mojo_buffer_backing.h View 1 chunk +0 lines, -39 lines 0 comments Download
D components/gles2/mojo_buffer_backing.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D components/gpu/public/interfaces/command_buffer.mojom View 1 chunk +0 lines, -55 lines 0 comments Download
D components/gpu/public/interfaces/context_provider.mojom View 1 chunk +0 lines, -28 lines 0 comments Download
D components/gpu/public/interfaces/gpu.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
D components/gpu/public/interfaces/gpu_capabilities.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D components/gpu/public/interfaces/viewport_parameter_listener.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M components/html_viewer/html_document.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
D components/surfaces/BUILD.gn View 1 chunk +0 lines, -54 lines 0 comments Download
D components/surfaces/DEPS View 1 chunk +0 lines, -10 lines 0 comments Download
D components/surfaces/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D components/surfaces/display_factory_impl.h View 1 chunk +0 lines, -47 lines 0 comments Download
D components/surfaces/display_factory_impl.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D components/surfaces/display_impl.h View 1 1 chunk +0 lines, -84 lines 0 comments Download
D components/surfaces/display_impl.cc View 1 1 chunk +0 lines, -151 lines 0 comments Download
D components/surfaces/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D components/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D components/surfaces/public/interfaces/display.mojom View 1 chunk +0 lines, -33 lines 0 comments Download
D components/surfaces/public/interfaces/quads.mojom View 1 chunk +0 lines, -212 lines 0 comments Download
D components/surfaces/public/interfaces/surface_id.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D components/surfaces/public/interfaces/surfaces.mojom View 1 chunk +0 lines, -77 lines 0 comments Download
D components/surfaces/surfaces_context_provider.h View 1 chunk +0 lines, -63 lines 0 comments Download
D components/surfaces/surfaces_context_provider.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D components/surfaces/surfaces_impl.h View 1 chunk +0 lines, -71 lines 0 comments Download
D components/surfaces/surfaces_impl.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D components/surfaces/surfaces_output_surface.h View 1 chunk +0 lines, -29 lines 0 comments Download
D components/surfaces/surfaces_output_surface.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D components/surfaces/surfaces_scheduler.h View 1 chunk +0 lines, -59 lines 0 comments Download
D components/surfaces/surfaces_scheduler.cc View 1 1 chunk +0 lines, -120 lines 0 comments Download
D components/surfaces/surfaces_service_application.h View 1 chunk +0 lines, -68 lines 0 comments Download
D components/surfaces/surfaces_service_application.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M components/view_manager/BUILD.gn View 1 6 chunks +4 lines, -7 lines 0 comments Download
M components/view_manager/display_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/display_manager.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + components/view_manager/gles2/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/gles2/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_driver.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_driver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_impl.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_impl.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_impl_observer.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_type_conversions.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/gles2/command_buffer_type_conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/gles2/gpu_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/view_manager/gles2/gpu_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/gpu_state.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/gpu_state.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/gles2/mojo_buffer_backing.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/gles2/mojo_buffer_backing.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/native_viewport_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/native_viewport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/native_viewport_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/native_viewport/onscreen_context_provider.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/view_manager/native_viewport/onscreen_context_provider.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/view_manager/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/public/cpp/view.h View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/public/interfaces/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
A + components/view_manager/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/context_provider.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/view_manager/public/interfaces/display.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/public/interfaces/gpu.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/gpu_capabilities.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/view_manager/public/interfaces/native_viewport.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/quads.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/surface_id.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/public/interfaces/surfaces.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M components/view_manager/public/interfaces/view_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/public/interfaces/viewport_parameter_listener.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/surfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
A + components/view_manager/surfaces/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/surfaces/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/view_manager/surfaces/display_factory_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/view_manager/surfaces/display_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/display_impl.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/surfaces/display_impl.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + components/view_manager/surfaces/main.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/surfaces_context_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_context_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/surfaces_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_output_surface.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/surfaces_scheduler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/view_manager/surfaces/surfaces_service_application.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/view_manager/surfaces/surfaces_service_application.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/view_manager/view_manager_app.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/view_manager_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/app/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/cc/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/cc/output_surface_mojo.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/converters/surfaces/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/surfaces_type_converters.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/converters/surfaces/surfaces_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/converters/surfaces/tests/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/runner/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/DEPS View 1 1 chunk +3 lines, -3 lines 0 comments Download
A mojo/runner/android/native_viewport_application_loader.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A mojo/runner/android/native_viewport_application_loader.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-05-21 21:20:01 UTC) #1
sky
Rubber stamp LGTM
5 years, 7 months ago (2015-05-21 21:22:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150093003/40001
5 years, 7 months ago (2015-05-21 23:59:17 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-22 01:03:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 01:05:06 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4b12854e86fcaeef3531f8955c6e4d0e1b7a3036
Cr-Commit-Position: refs/heads/master@{#331039}

Powered by Google App Engine
This is Rietveld 408576698