Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1149873010: cc: Remove IOSurface explicit support in VideoLayerImpl. (Closed)

Created:
5 years, 6 months ago by Daniele Castagna
Modified:
5 years, 6 months ago
Reviewers:
danakj, jfroy
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove IOSurface support in VideoLayerImpl. VideoFrame backed by IOSurfaces are not used for playback at the moment. Support for IOSurfaces will be available via GpuMemoryBuffers. This CL removes the explicit support for IOSurfaces from VideoLayerImpl. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/ef2b44689b9a4cc231a8546a27a6da498b4cd39d Cr-Commit-Position: refs/heads/master@{#332088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Daniele Castagna
5 years, 6 months ago (2015-05-30 00:12:56 UTC) #2
danakj
LGTM
5 years, 6 months ago (2015-05-30 00:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149873010/1
5 years, 6 months ago (2015-05-30 00:15:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-30 00:40:14 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef2b44689b9a4cc231a8546a27a6da498b4cd39d Cr-Commit-Position: refs/heads/master@{#332088}
5 years, 6 months ago (2015-05-30 00:40:58 UTC) #7
vabr (Chromium)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1162443005/ by vabr@chromium.org. ...
5 years, 6 months ago (2015-06-01 07:40:59 UTC) #8
vabr (Chromium)
5 years, 6 months ago (2015-06-01 10:31:42 UTC) #9
Message was sent while issue was closed.
On 2015/06/01 07:40:59, vabr (Chromium) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1162443005/ by mailto:vabr@chromium.org.
> 
> The reason for reverting is: Speculatively reverting this as the only suspect
of
> breaking Mac WebGL tests in
>
https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%2...
> and
>
https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Release/bui...
> 
> Your sheriff.

Revert worked, more details in http://crbug.com/494964.

Powered by Google App Engine
This is Rietveld 408576698