Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1162443005: Revert of cc: Remove IOSurface explicit support in VideoLayerImpl. (Closed)

Created:
5 years, 6 months ago by vabr (Chromium)
Modified:
5 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove IOSurface explicit support in VideoLayerImpl. (patchset #1 id:1 of https://codereview.chromium.org/1149873010/) Reason for revert: Speculatively reverting this as the only suspect of breaking Mac WebGL tests in https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20%28Intel%29/builds/51919 and https://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Release/builds/39021 Your sheriff Original issue's description: > cc: Remove IOSurface support in VideoLayerImpl. > > VideoFrame backed by IOSurfaces are not used for playback at the moment. > Support for IOSurfaces will be available via GpuMemoryBuffers. > > This CL removes the explicit support for IOSurfaces from VideoLayerImpl. > > BUG= > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/ef2b44689b9a4cc231a8546a27a6da498b4cd39d > Cr-Commit-Position: refs/heads/master@{#332088} TBR=jfroy@chromium.org,danakj@chromium.org,dcastagna@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/adf797a58dababb597451f6c0302e32d41188a5e Cr-Commit-Position: refs/heads/master@{#332167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Created Revert of cc: Remove IOSurface explicit support in VideoLayerImpl.
5 years, 6 months ago (2015-06-01 07:40:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1162443005/1
5 years, 6 months ago (2015-06-01 07:41:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 07:42:00 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/adf797a58dababb597451f6c0302e32d41188a5e Cr-Commit-Position: refs/heads/master@{#332167}
5 years, 6 months ago (2015-06-01 07:42:59 UTC) #4
vabr (Chromium)
5 years, 6 months ago (2015-06-01 10:31:52 UTC) #5
Message was sent while issue was closed.
On 2015/06/01 07:42:59, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/adf797a58dababb597451f6c0302e32d41188a5e
> Cr-Commit-Position: refs/heads/master@{#332167}

Revert worked, more details in http://crbug.com/494964.

Powered by Google App Engine
This is Rietveld 408576698