Add the DelegatingRenderer class with its initialize path.

Add the DelegatingRenderer class with its initialize path.

It's a skeleton class that can be initialized so that we can test with it.

Tests:
LayerTreeHostTest.PartialUpdatesWithDelegatingRendererAndGLContent
LayerTreeHostTest.PartialUpdatesWithDelegatingRendererAndSoftwareContent
LayerTreeHostImplTest.partialSwapReceivesDamageRect

R=piman
BUG=146080
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171927

[danakj, 2012-12-07 20:12:26]

Oh, I'll update the description. But the tests it mentions are present now.

[piman, 2012-12-07 22:37:35]

https://codereview.chromium.org/11464007/diff/8001/cc/delegating_renderer.h
File cc/delegating_renderer.h (right):

https://codereview.chromium.org/11464007/diff/8001/cc/delegating_renderer.h#n...
cc/delegating_renderer.h:39: public
WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback
NON_EXPORTED_BASE

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc
File cc/gl_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc#newcode85
cc/gl_renderer.cc:85: bool GLRenderer::initialize(ResourceProvider*
resourceProvider)
why? (you already have it).

[danakj, 2012-12-07 22:41:01]

https://codereview.chromium.org/11464007/diff/8001/cc/delegating_renderer.h
File cc/delegating_renderer.h (right):

https://codereview.chromium.org/11464007/diff/8001/cc/delegating_renderer.h#n...
cc/delegating_renderer.h:39: public
WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback
On 2012/12/07 22:37:35, piman wrote:
> NON_EXPORTED_BASE

k

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc
File cc/gl_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc#newcode85
cc/gl_renderer.cc:85: bool GLRenderer::initialize(ResourceProvider*
resourceProvider)
On 2012/12/07 22:37:35, piman wrote:
> why? (you already have it).

The provider isn't saved, right? Just the context3d is.

[danakj, 2012-12-07 22:46:02]

Done, ptal

[piman, 2012-12-07 22:53:12]

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc
File cc/gl_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc#newcode85
cc/gl_renderer.cc:85: bool GLRenderer::initialize(ResourceProvider*
resourceProvider)
On 2012/12/07 22:41:01, danakj wrote:
> On 2012/12/07 22:37:35, piman wrote:
> > why? (you already have it).
> 
> The provider isn't saved, right? Just the context3d is.

It is saved in the DirectRenderer, that's the one you're using below anyway!
(m_resourceProvider)

[danakj, 2012-12-07 22:54:12]

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc
File cc/gl_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/8001/cc/gl_renderer.cc#newcode85
cc/gl_renderer.cc:85: bool GLRenderer::initialize(ResourceProvider*
resourceProvider)
On 2012/12/07 22:53:13, piman wrote:
> On 2012/12/07 22:41:01, danakj wrote:
> > On 2012/12/07 22:37:35, piman wrote:
> > > why? (you already have it).
> > 
> > The provider isn't saved, right? Just the context3d is.
> 
> It is saved in the DirectRenderer, that's the one you're using below anyway!
> (m_resourceProvider)

OH >_< I copied and pasted and didn't notice the m_ was working.

Ok thanks!

[danakj, 2012-12-07 23:03:40]

Fixed, PTAL

[piman, 2012-12-07 23:07:26]

LGTM, thanks!!

[commit-bot: I haz the power, 2012-12-08 00:15:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11464007/4018

[boliu, 2012-12-08 19:47:15]

https://codereview.chromium.org/11464007/diff/4018/cc/delegating_renderer.cc
File cc/delegating_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/4018/cc/delegating_renderer.cc#...
cc/delegating_renderer.cc:2: * Copyright (C) 2012 Google Inc. All rights
reserved.
This file and its header file have the Google license header instead of the
Chromium one. Was this intentional?

I am asking because if this is intentional, I think we will need to need to
white list this file for android webview build. +torne who knows more about
license issues regarding android webview.

[danakj, 2012-12-08 19:50:03]

https://codereview.chromium.org/11464007/diff/4018/cc/delegating_renderer.cc
File cc/delegating_renderer.cc (right):

https://codereview.chromium.org/11464007/diff/4018/cc/delegating_renderer.cc#...
cc/delegating_renderer.cc:2: * Copyright (C) 2012 Google Inc. All rights
reserved.
On 2012/12/08 19:47:16, boliu wrote:
> This file and its header file have the Google license header instead of the
> Chromium one. Was this intentional?
> 
> I am asking because if this is intentional, I think we will need to need to
> white list this file for android webview build. +torne who knows more about
> license issues regarding android webview.

Oh, no it was not, I copy/pasted that in, and didn't notice it was different.

I'd be happy to review a fix.