Fixed unclickable X button in App Info dialog in RTL languages.

Fixed unclickable X button in App Info dialog in RTL languages.

BubbleFrameView: Replaced GetCloseButtonBounds with
GetCloseButtonMirroredBounds. Now returns the RTL-mirrored bounds, which
is necessary for the App Info dialog's FullSizeBubbleFrameView to
correctly target events to the close button in RTL mode.

BUG=474559
TEST=Change language to Arabic. Go to chrome://extensions; click
"Details" on any extension. Click X button. Should close dialog.

Committed: https://crrev.com/a429208d1c11c1330801fca7420d8796e97f8a5a
Cr-Commit-Position: refs/heads/master@{#330678}

[Matt Giuca, 2015-05-19 03:03:31]

mgiuca@chromium.org changed reviewers:
+ benwells@chromium.org, msw@chromium.org

[Matt Giuca, 2015-05-19 03:03:32]

benwells@chromium.org: Please review changes in
chrome/browser/ui/views/app_list.

msw@chromium.org: Please review changes in ui/views/bubble.

[msw, 2015-05-19 17:06:20]

lgtm with a nit

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
File ui/views/bubble/bubble_frame_view.h (right):

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
ui/views/bubble/bubble_frame_view.h:91: gfx::Rect GetCloseButtonMirroredBounds()
const;
nit: I wouldn't bother renaming the function.

[benwells, 2015-05-19 22:04:01]

lgtm

[Matt Giuca, 2015-05-19 23:47:23]

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
File ui/views/bubble/bubble_frame_view.h (right):

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
ui/views/bubble/bubble_frame_view.h:91: gfx::Rect GetCloseButtonMirroredBounds()
const;
On 2015/05/19 17:06:20, msw wrote:
> nit: I wouldn't bother renaming the function.

I think it's pretty important to change the name, or someone could run into the
opposite problem (expecting the "normal" non-flipped bounds and getting weird
behaviour in RTL).

In that case, the person would want to re-introduce GetCloseButtonBounds as a
separate method. (I didn't think of this CL as renaming, but rather deleting one
function and adding another.)

[msw, 2015-05-20 00:20:46]

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
File ui/views/bubble/bubble_frame_view.h (right):

https://codereview.chromium.org/1144853002/diff/1/ui/views/bubble/bubble_fram...
ui/views/bubble/bubble_frame_view.h:91: gfx::Rect GetCloseButtonMirroredBounds()
const;
On 2015/05/19 23:47:23, Matt Giuca wrote:
> On 2015/05/19 17:06:20, msw wrote:
> > nit: I wouldn't bother renaming the function.
> 
> I think it's pretty important to change the name, or someone could run into
the
> opposite problem (expecting the "normal" non-flipped bounds and getting weird
> behaviour in RTL).
> 
> In that case, the person would want to re-introduce GetCloseButtonBounds as a
> separate method. (I didn't think of this CL as renaming, but rather deleting
one
> function and adding another.)

Acknowledged.

[Matt Giuca, 2015-05-20 01:09:36]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2015-05-20 01:10:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1144853002/1

[commit-bot: I haz the power, 2015-05-20 02:06:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-20 02:08:41]

Patchset 1 (id:??) landed as
https://crrev.com/a429208d1c11c1330801fca7420d8796e97f8a5a
Cr-Commit-Position: refs/heads/master@{#330678}