Fixed unclickable X button in App Info dialog in RTL languages.

ui/views/bubble/bubble_frame_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
@@ skipping 70 matching lines @@
   // does not fit on the monitor and |adjust_if_offscreen| is true.
   gfx::Rect GetUpdatedWindowBounds(const gfx::Rect& anchor_rect,
                                    gfx::Size client_size,
                                    bool adjust_if_offscreen);
 
  protected:
   // Returns the available screen bounds if the frame were to show in |rect|.
   virtual gfx::Rect GetAvailableScreenBounds(const gfx::Rect& rect);
 
   bool IsCloseButtonVisible() const;
-  gfx::Rect GetCloseButtonBounds() const;
+  gfx::Rect GetCloseButtonMirroredBounds() const;

[msw, 2015/05/19 17:06:20]

nit: I wouldn't bother renaming the function.

[Matt Giuca, 2015/05/19 23:47:23]

I think it's pretty important to change the name, or someone could run into the
opposite problem (expecting the "normal" non-flipped bounds and getting weird
behaviour in RTL).

In that case, the person would want to re-introduce GetCloseButtonBounds as a
separate method. (I didn't think of this CL as renaming, but rather deleting one
function and adding another.)

[msw, 2015/05/20 00:20:45]

Acknowledged.

 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);
 
   // Mirrors the bubble's arrow location on the |vertical| or horizontal axis,
   // if the generated window bounds don't fit in the monitor bounds.
   void MirrorArrowIfOffScreen(bool vertical,
                               const gfx::Rect& anchor_rect,
                               const gfx::Size& client_size);
 
@@ skipping 19 matching lines @@
   // When supplied, this view is placed in the titlebar between the title and
   // (x) close button.
   View* titlebar_extra_view_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleFrameView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_FRAME_VIEW_H_