Fixed unclickable X button in App Info dialog in RTL languages.

ui/views/bubble/bubble_frame_view.h

Index: ui/views/bubble/bubble_frame_view.h
diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h
index e86415d0b866b4ccc2f0fa0a7238260c92aa8c6e..f756209cf18ae8b10231dda345e2365e511c9212 100644
--- a/ui/views/bubble/bubble_frame_view.h
+++ b/ui/views/bubble/bubble_frame_view.h
@@ -88,7 +88,7 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
   virtual gfx::Rect GetAvailableScreenBounds(const gfx::Rect& rect);
 
   bool IsCloseButtonVisible() const;
-  gfx::Rect GetCloseButtonBounds() const;
+  gfx::Rect GetCloseButtonMirroredBounds() const;

[msw, 2015/05/19 17:06:20]

nit: I wouldn't bother renaming the function.

[Matt Giuca, 2015/05/19 23:47:23]

I think it's pretty important to change the name, or someone could run into the
opposite problem (expecting the "normal" non-flipped bounds and getting weird
behaviour in RTL).

In that case, the person would want to re-introduce GetCloseButtonBounds as a
separate method. (I didn't think of this CL as renaming, but rather deleting one
function and adding another.)

[msw, 2015/05/20 00:20:45]

Acknowledged.

 
  private:
   FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);