Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/ui/views/app_list/app_list_dialog_container.cc

Issue 1144853002: Fixed unclickable X button in App Info dialog in RTL languages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view.h » ('j') | ui/views/bubble/bubble_frame_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/app_list/app_list_dialog_container.cc
diff --git a/chrome/browser/ui/views/app_list/app_list_dialog_container.cc b/chrome/browser/ui/views/app_list/app_list_dialog_container.cc
index e86ca7dfb8b4cd3123b0e655d15638abc6cb4562..3ff64caca2bb5e8106bcd39f0b18953893f9bc8c 100644
--- a/chrome/browser/ui/views/app_list/app_list_dialog_container.cc
+++ b/chrome/browser/ui/views/app_list/app_list_dialog_container.cc
@@ -168,8 +168,13 @@ class FullSizeBubbleFrameView : public views::BubbleFrameView {
const gfx::Rect& rect) const override {
// Make sure click events can still reach the close button, even if the
// ClientView overlaps it.
- if (IsCloseButtonVisible() && GetCloseButtonBounds().Intersects(rect))
+ // NOTE: |rect| is in the mirrored coordinate space, so we must use the
+ // close button's mirrored bounds to correctly target the close button when
+ // in RTL mode.
+ if (IsCloseButtonVisible() &&
+ GetCloseButtonMirroredBounds().Intersects(rect)) {
return true;
+ }
return views::BubbleFrameView::DoesIntersectRect(target, rect);
}
« no previous file with comments | « no previous file | ui/views/bubble/bubble_frame_view.h » ('j') | ui/views/bubble/bubble_frame_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698