|
|
Eliminates all ash dependencies from WindowModalityController.
This is in preparation for moving it to corewm so this code can be shared with desktop-aura.
This required moving GetActivatableWindow to ActivationClient (instead of ash-specific ActivationController) and consolidating the modal parent property.
For a subsequent CL: moving the test's dependencies (ChildModalWindow, CaptureTrackingView) from ash/test to views/test.
http://crbug.com/158115
R=rouslan@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170313
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+113 lines, -72 lines) |
Patch |
 |
M |
ash/test/child_modal_window.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
ash/wm/activation_controller.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ash/wm/activation_controller.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
ash/wm/ash_activation_controller.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_modality_controller.h
|
View
|
1
2
3
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_modality_controller.cc
|
View
|
1
2
3
|
6 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_modality_controller_unittest.cc
|
View
|
1
2
3
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_properties.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
ash/wm/window_properties.cc
|
View
|
1
2
3
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
ash/wm/window_util.cc
|
View
|
1
2
3
|
3 chunks |
+7 lines, -21 lines |
0 comments
|
Download
|
|
M |
chrome/browser/ui/views/constrained_window_views.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/aura/client/activation_client.h
|
View
|
1
2
3
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/aura/test/test_activation_client.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ui/aura/test/test_activation_client.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/views/corewm/focus_controller.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
ui/views/corewm/focus_controller.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/views/corewm/window_util.h
|
View
|
1
2
3
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/views/corewm/window_util.cc
|
View
|
1
2
3
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
|
M |
ui/views/widget/desktop_aura/desktop_activation_client.h
|
View
|
1
2
3
|
2 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
ui/views/widget/desktop_aura/desktop_activation_client.cc
|
View
|
1
2
3
|
2 chunks |
+17 lines, -17 lines |
0 comments
|
Download
|
Total messages: 5 (0 generated)
|
Chromium Code Reviews
Issue
11418224:
Eliminates all ash dependencies from WindowModalityController. (Closed)
