Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2033)

Unified Diff: ash/wm/window_modality_controller_unittest.cc

Issue 11418224: Eliminates all ash dependencies from WindowModalityController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/window_modality_controller.cc ('k') | ash/wm/window_properties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_modality_controller_unittest.cc
===================================================================
--- ash/wm/window_modality_controller_unittest.cc (revision 170295)
+++ ash/wm/window_modality_controller_unittest.cc (working copy)
@@ -219,7 +219,7 @@
w2->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_WINDOW);
aura::Window* wt;
- wt = wm::GetModalTransient(w1.get());
+ wt = GetModalTransient(w1.get());
ASSERT_EQ(static_cast<aura::Window*>(NULL), wt);
// Parent w2 to w1. It should get parented to the parent of w1.
@@ -228,12 +228,12 @@
EXPECT_EQ(-2, w1->parent()->children().at(1)->id());
// Request the modal transient window for w1, it should be w2.
- wt = wm::GetModalTransient(w1.get());
+ wt = GetModalTransient(w1.get());
ASSERT_NE(static_cast<aura::Window*>(NULL), wt);
EXPECT_EQ(-2, wt->id());
// Request the modal transient window for w11, it should also be w2.
- wt = wm::GetModalTransient(w11.get());
+ wt = GetModalTransient(w11.get());
ASSERT_NE(static_cast<aura::Window*>(NULL), wt);
EXPECT_EQ(-2, wt->id());
}
@@ -359,7 +359,7 @@
// |child| window.
// - Focus should follow the active window.
TEST_F(WindowModalityControllerTest, ChildModal) {
- ash::test::ChildModalParent* delegate = new ash::test::ChildModalParent;
+ test::ChildModalParent* delegate = new test::ChildModalParent;
views::Widget* widget = views::Widget::CreateWindowWithBounds(
delegate, gfx::Rect(0, 0, 400, 400));
widget->Show();
@@ -418,7 +418,7 @@
// Same as |ChildModal| test, but using |EventGenerator| rather than bypassing
// it by calling |ActivateWindow|.
TEST_F(WindowModalityControllerTest, ChildModalEventGenerator) {
- ash::test::ChildModalParent* delegate = new ash::test::ChildModalParent;
+ test::ChildModalParent* delegate = new test::ChildModalParent;
views::Widget* widget = views::Widget::CreateWindowWithBounds(
delegate, gfx::Rect(0, 0, 400, 400));
widget->Show();
@@ -532,7 +532,7 @@
scoped_ptr<aura::Window> w4(
CreateTestWindowInShellWithDelegate(&d, -2, gfx::Rect()));
w4->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_CHILD);
- ash::wm::SetModalParent(w4.get(), w2.get());
+ SetModalParent(w4.get(), w2.get());
w1->AddTransientChild(w4.get());
wm::ActivateWindow(w1.get());
« no previous file with comments | « ash/wm/window_modality_controller.cc ('k') | ash/wm/window_properties.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698