Prepare password_bubble_experiment and password_manager_util for componentisation

Prepare password_bubble_experiment and password_manager_util for componentisation

This CL removes some unneeded //chrome dependencies in password manager utilities. The goal is to make those files movable to the password manager component. The move will happen in a separate CL.

BUG=486739
Committed: https://crrev.com/465933b5e78eca669273df5f1ef5351e2cd3cbf5
Cr-Commit-Position: refs/heads/master@{#330805}

[vabr (Chromium), 2015-05-19 15:24:38]

vabr@chromium.org changed reviewers:
+ engedy@chromium.org

[vabr (Chromium), 2015-05-19 15:24:39]

Hi Balázs,

Could you PTAL?

For context, this is needed for
https://chromereviews.googleplex.com/195307013/#msg18.

Thanks!
Vaclav

[engedy, 2015-05-19 15:52:08]

On 2015/05/19 15:24:39, vabr (Chromium) wrote:
> Hi Balázs,
> 
> Could you PTAL?
> 
> For context, this is needed for
> https://chromereviews.googleplex.com/195307013/#msg18.
> 
> Thanks!
> Vaclav

Vaclav, I will not be able to take a look at this until next week. Could you
please re-assign?

[Mike West, 2015-05-19 16:00:48]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-05-19 16:00:49]

LGTM. The android bots aren't at all happy with the change, however (and you'll
need someone else to stamp that code anyway).

[vabr (Chromium), 2015-05-19 17:02:47]

vabr@chromium.org changed reviewers:
+ isherman@chromium.org, newt@chromium.org, stevenjb@chromium.org
- engedy@chromium.org

[vabr (Chromium), 2015-05-19 17:02:49]

Hi all.

Please review:

newt@ -- chrome/browser/android/password_ui_view_android.cc

isherman@ --
chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

stevenjb@ -- chrome/browser/ui/webui/options/browser_options_handler.cc


Mike, the Android compilation looks better now. Unless you speak up, I'll assume
your approval still holds. :)

Thanks all!
Vaclav

[vabr (Chromium), 2015-05-19 17:03:32]

Sorry, a typo!

stevenjb@ -- please review both files in chrome/browser/ui/webui/options/*

Thanks,
Vaclav

[newt (away), 2015-05-19 18:00:15]

password_ui_view_android.cc lgtm

[Ilya Sherman, 2015-05-19 22:54:54]

chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc lgtm

[vabr (Chromium), 2015-05-20 07:04:51]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org

[vabr (Chromium), 2015-05-20 07:04:52]

Steve appears to be OOO, and all the ui/webui/options OWNERS are in U.S.

Bernhard, could you review chrome/browser/ui/webui/options/* ?

Thanks!
Vaclav

[vabr (Chromium), 2015-05-20 07:08:28]

vabr@chromium.org changed reviewers:
+ estade@chromium.org
- stevenjb@chromium.org

[vabr (Chromium), 2015-05-20 07:08:29]

Aaand Bernhard is apparently also OOO.

Evan, could you please review chrome/browser/ui/webui/options/* ?

Thanks!
Vaclav

[vabr (Chromium), 2015-05-20 07:09:05]

vabr@chromium.org changed reviewers:
- bauerb@chromium.org

[Bernhard Bauer, 2015-05-20 18:05:26]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-05-20 18:05:27]

I am in *an* office right now... :-)

Web UI LGTM

[vabr (Chromium), 2015-05-20 19:56:07]

On 2015/05/20 18:05:27, Bernhard Bauer wrote:
> I am in *an* office right now... :-)
> 
> Web UI LGTM

Thanks, Bernhard!
And thanks all reviewers.
Sending to CQ.
Cheers,
Vaclav

[vabr (Chromium), 2015-05-20 19:56:14]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2015-05-20 19:56:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1141413002/#ps40001
(title: "Fix Android 2")

[commit-bot: I haz the power, 2015-05-20 19:56:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141413002/40001

[commit-bot: I haz the power, 2015-05-20 21:25:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-20 21:26:59]

Patchset 3 (id:??) landed as
https://crrev.com/465933b5e78eca669273df5f1ef5351e2cd3cbf5
Cr-Commit-Position: refs/heads/master@{#330805}