chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 1141413002: Prepare password_bubble_experiment and password_manager_util for componentisation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 1141413002: Prepare password_bubble_experiment and password_manager_util for componentisation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_bubble_experiment.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index ce012680538b26a6ad2f1008f75270b2a09e6157..e83872e1a91320f9ccb2a29c331e5832f8a3131f 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -310,7 +310,8 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {

IDS_NETWORK_PREDICTION_ENABLED_DESCRIPTION },

{ "passwordManagerEnabled",

password_bubble_experiment::IsSmartLockBrandingEnabled(

- Profile::FromWebUI(web_ui())) ?

+ ProfileSyncServiceFactory::GetForProfile(

+ Profile::FromWebUI(web_ui()))) ?

IDS_OPTIONS_PASSWORD_MANAGER_SMART_LOCK_ENABLE :

IDS_OPTIONS_PASSWORD_MANAGER_ENABLE },

{ "passwordsAndAutofillGroupName",