Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/android/password_ui_view_android.cc

Issue 1141413002: Prepare password_bubble_experiment and password_manager_util for componentisation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Android 2 Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/password_ui_view_android.h" 5 #include "chrome/browser/android/password_ui_view_android.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "base/android/jni_weak_ref.h" 8 #include "base/android/jni_weak_ref.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
11 #include "base/prefs/pref_service.h" 11 #include "base/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile_manager.h" 12 #include "chrome/browser/profiles/profile_manager.h"
13 #include "chrome/browser/sync/profile_sync_service.h"
14 #include "chrome/browser/sync/profile_sync_service_factory.h"
13 #include "chrome/browser/ui/passwords/password_bubble_experiment.h" 15 #include "chrome/browser/ui/passwords/password_bubble_experiment.h"
14 #include "chrome/common/pref_names.h" 16 #include "chrome/common/pref_names.h"
15 #include "chrome/common/url_constants.h" 17 #include "chrome/common/url_constants.h"
16 #include "components/autofill/core/common/password_form.h" 18 #include "components/autofill/core/common/password_form.h"
17 #include "components/password_manager/core/browser/affiliation_utils.h" 19 #include "components/password_manager/core/browser/affiliation_utils.h"
18 #include "components/password_manager/core/common/experiments.h" 20 #include "components/password_manager/core/common/experiments.h"
19 #include "components/password_manager/core/common/password_manager_switches.h" 21 #include "components/password_manager/core/common/password_manager_switches.h"
20 #include "jni/PasswordUIView_jni.h" 22 #include "jni/PasswordUIView_jni.h"
21 23
22 using base::android::ConvertUTF16ToJavaString; 24 using base::android::ConvertUTF16ToJavaString;
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 env, chrome::kPasswordManagerAccountDashboardURL).Release(); 112 env, chrome::kPasswordManagerAccountDashboardURL).Release();
111 } 113 }
112 114
113 static jboolean ShouldDisplayManageAccountLink( 115 static jboolean ShouldDisplayManageAccountLink(
114 JNIEnv* env, jclass) { 116 JNIEnv* env, jclass) {
115 return password_manager::ManageAccountLinkExperimentEnabled(); 117 return password_manager::ManageAccountLinkExperimentEnabled();
116 } 118 }
117 119
118 static jboolean ShouldUseSmartLockBranding( 120 static jboolean ShouldUseSmartLockBranding(
119 JNIEnv* env, jclass) { 121 JNIEnv* env, jclass) {
120 return password_bubble_experiment::IsSmartLockBrandingEnabled( 122 const ProfileSyncService* sync_service =
121 ProfileManager::GetLastUsedProfile()); 123 ProfileSyncServiceFactory::GetForProfile(
124 ProfileManager::GetLastUsedProfile());
125 return password_bubble_experiment::IsSmartLockBrandingEnabled(sync_service);
122 } 126 }
123 127
124 // static 128 // static
125 static jlong Init(JNIEnv* env, jobject obj) { 129 static jlong Init(JNIEnv* env, jobject obj) {
126 PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj); 130 PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj);
127 return reinterpret_cast<intptr_t>(controller); 131 return reinterpret_cast<intptr_t>(controller);
128 } 132 }
129 133
130 bool PasswordUIViewAndroid::RegisterPasswordUIViewAndroid(JNIEnv* env) { 134 bool PasswordUIViewAndroid::RegisterPasswordUIViewAndroid(JNIEnv* env) {
131 return RegisterNativesImpl(env); 135 return RegisterNativesImpl(env);
132 } 136 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/password_manager_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698