chrome/browser/ui/passwords/password_bubble_experiment.cc - Issue 1141413002: Prepare password_bubble_experiment and password_manager_util for componentisation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/password_bubble_experiment.cc

Issue 1141413002: Prepare password_bubble_experiment and password_manager_util for componentisation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Android 2 Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/password_bubble_experiment.h ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/password_bubble_experiment.cc

diff --git a/chrome/browser/ui/passwords/password_bubble_experiment.cc b/chrome/browser/ui/passwords/password_bubble_experiment.cc

index aca8198c6e8caea6cbbdaff564305ad51bb699cf..50ec27f2c10cf071d9679c3b7d104650ec4d787e 100644

--- a/chrome/browser/ui/passwords/password_bubble_experiment.cc

+++ b/chrome/browser/ui/passwords/password_bubble_experiment.cc

@@ -5,9 +5,8 @@

#include "chrome/browser/ui/passwords/password_bubble_experiment.h"

#include "base/metrics/field_trial.h"

+#include "base/prefs/pref_service.h"

#include "chrome/browser/password_manager/password_manager_util.h"

-#include "chrome/browser/signin/signin_manager_factory.h"

-#include "chrome/browser/sync/profile_sync_service_factory.h"

namespace password_bubble_experiment {

namespace {

@@ -23,9 +22,7 @@ void RecordBubbleClosed(

// TODO(vasilii): store the statistics.

}

-bool IsSmartLockBrandingEnabled(Profile* profile) {

- const ProfileSyncService* sync_service =

- ProfileSyncServiceFactory::GetForProfile(profile);

+bool IsSmartLockBrandingEnabled(const sync_driver::SyncService* sync_service) {

return password_manager_util::GetPasswordSyncState(sync_service) ==

password_manager::SYNCING_NORMAL_ENCRYPTION &&

base::FieldTrialList::FindFullName(kBrandingExperimentName) ==