chrome.platformKeys: Add filtering by certificate types

chrome.platformKeys: Add filtering by certificate types

This CL adds the possibility to filter by certificate type
when issuing a certificate request to chrome.platformKeys API.

BUG=488367
TEST=browser_tests:PlatformKeysTest.Basic

Committed: https://crrev.com/e195ec899c5b6f8b31cd0ecec73a1144442ee1af
Cr-Commit-Position: refs/heads/master@{#330721}

[cschuet (SLOW), 2015-05-19 09:44:57]

cschuet@chromium.org changed reviewers:
+ pneubeck@chromium.org

[pneubeck (no reviews), 2015-05-19 10:09:00]

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys.h (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys.h:16: #include
"net/ssl/ssl_client_cert_type.h"
not required anymore?

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:761: void
SelectClientCertificates(const ClientCertificateRequest& request,
please check and update the documentation of this SelectClientCertificates in
platform_keys.h .

You should also change the |request| argument from  ClientCertificateRequest to
the type of certificate_authorities (as const&).

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:769: // Currently we
omit passing down the requested certificate type to the NSS
s/NSS/net/

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:770: // layer, as NSS
does not support filtering certificates by type. Rather we
s/NSS/it/

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:772: //
PlaformKeysService::GotMatchingCerts().
... of all type and the caller has to apply filtering afterwards.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:513:
net::X509Certificate::PublicKeyType key_type_tmp =
maybe key_type_tmp -> actual_key_type

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:515: size_t
key_size_bits_tmp = 0;
maybe s/_tmp//
or maybe call it unused_key_size

https://codereview.chromium.org/1141253003/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/platform_keys.idl (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/platform_keys.idl:35: // empty list, however, all
available certificates will be returned.
s/all available certificate/certificates of any type/

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/platform_keys/basic.js (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/platform_keys/basic.js:200: var requestRSA
= {
as these two variables are used only once, just make them local to the functions
that use them.

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/platform_keys/basic.js:271: 0,
matches.length,
is this autoformatted?

[cschuet (SLOW), 2015-05-19 11:36:23]

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys.h (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys.h:16: #include
"net/ssl/ssl_client_cert_type.h"
On 2015/05/19 10:08:59, pneubeck wrote:
> not required anymore?

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_nss.cc (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:761: void
SelectClientCertificates(const ClientCertificateRequest& request,
On 2015/05/19 10:09:00, pneubeck wrote:
> please check and update the documentation of this SelectClientCertificates in
> platform_keys.h .
> 
> You should also change the |request| argument from  ClientCertificateRequest
to
> the type of certificate_authorities (as const&).

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:769: // Currently we
omit passing down the requested certificate type to the NSS
On 2015/05/19 10:09:00, pneubeck wrote:
> s/NSS/net/

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:770: // layer, as NSS
does not support filtering certificates by type. Rather we
On 2015/05/19 10:09:00, pneubeck wrote:
> s/NSS/it/

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_nss.cc:772: //
PlaformKeysService::GotMatchingCerts().
On 2015/05/19 10:09:00, pneubeck wrote:
> ... of all type and the caller has to apply filtering afterwards.

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:513:
net::X509Certificate::PublicKeyType key_type_tmp =
On 2015/05/19 10:09:00, pneubeck wrote:
> maybe key_type_tmp -> actual_key_type

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/browser/chromeos/pla...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:515: size_t
key_size_bits_tmp = 0;
On 2015/05/19 10:09:00, pneubeck wrote:
> maybe s/_tmp//
> or maybe call it unused_key_size

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/platform_keys.idl (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/platform_keys.idl:35: // empty list, however, all
available certificates will be returned.
On 2015/05/19 10:09:00, pneubeck wrote:
> s/all available certificate/certificates of any type/

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
File chrome/test/data/extensions/api_test/platform_keys/basic.js (right):

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/platform_keys/basic.js:200: var requestRSA
= {
On 2015/05/19 10:09:00, pneubeck wrote:
> as these two variables are used only once, just make them local to the
functions
> that use them.

Done.

https://codereview.chromium.org/1141253003/diff/1/chrome/test/data/extensions...
chrome/test/data/extensions/api_test/platform_keys/basic.js:271: 0,
matches.length,
On 2015/05/19 10:09:00, pneubeck wrote:
> is this autoformatted?

Done.

[pneubeck (no reviews), 2015-05-19 11:40:20]

lgtm

[cschuet (SLOW), 2015-05-19 11:55:49]

cschuet@chromium.org changed reviewers:
+ mkearney@chromium.org

[cschuet (SLOW), 2015-05-19 11:55:49]

mkearney@chromium.org: Please review changes in 
chrome/common/extensions/api/platform_keys.idl

[cschuet (SLOW), 2015-05-20 07:28:02]

cschuet@chromium.org changed reviewers:
- mkearney@chromium.org

[cschuet (SLOW), 2015-05-20 07:28:22]

cschuet@chromium.org changed reviewers:
+ mkwst@chromium.org

[cschuet (SLOW), 2015-05-20 07:28:22]

mkwst@chromium.org: Please review changes in 
chrome/common/extensions/api/platform_keys.idl

[Mike West, 2015-05-20 07:29:37]

Comment changes in the IDL LGTM.

[cschuet (SLOW), 2015-05-20 07:30:35]

The CQ bit was checked by cschuet@chromium.org

[commit-bot: I haz the power, 2015-05-20 07:30:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1141253003/40001

[commit-bot: I haz the power, 2015-05-20 09:52:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-20 09:53:01]

Patchset 3 (id:??) landed as
https://crrev.com/e195ec899c5b6f8b31cd0ecec73a1144442ee1af
Cr-Commit-Position: refs/heads/master@{#330721}