chrome.platformKeys: Add filtering by certificate types

chrome/browser/chromeos/platform_keys/platform_keys_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/platform_keys/platform_keys_service.h"
 
 #include "base/base64.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/values.h"
@@ skipping 480 matching lines @@
   // will be empty. If an error occurred, |matches| will be null and
   // |error_message| contain an error message.
   void GotMatchingCerts(scoped_ptr<net::CertificateList> matches,
                         const std::string& error_message) {
     if (!error_message.empty()) {
       next_step_ = Step::DONE;
       callback_.Run(nullptr /* no certificates */, error_message);
       DoStep();
       return;
     }
-    matches_.swap(*matches);
+
+    // If the type field does not contain any entries, all certificate types
+    // shall be returned.
+    if (request_.certificate_key_types.size() == 0) {
+      matches_.swap(*matches);
+      DoStep();
+      return;
+    }
+
+    // Filter the retrieved certificates allowing only those whose type is
+    // contained in the type list of the certificate request.
+    for (scoped_refptr<net::X509Certificate>& certificate : *matches) {
+      net::X509Certificate::PublicKeyType key_type_tmp =

[pneubeck (no reviews), 2015/05/19 10:09:00]

maybe key_type_tmp -> actual_key_type

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+          net::X509Certificate::kPublicKeyTypeUnknown;
+      size_t key_size_bits_tmp = 0;

[pneubeck (no reviews), 2015/05/19 10:09:00]

maybe s/_tmp//
or maybe call it unused_key_size

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+      net::X509Certificate::GetPublicKeyInfo(certificate->os_cert_handle(),
+                                             &key_size_bits_tmp, &key_type_tmp);
+      const std::vector<net::X509Certificate::PublicKeyType>& accepted_types =
+          request_.certificate_key_types;
+      if (std::find(accepted_types.begin(), accepted_types.end(),
+                    key_type_tmp) != accepted_types.end()) {
+        matches_.push_back(certificate.Pass());
+      }
+    }
     DoStep();
   }
 
   // Calls |service_->select_delegate_->Select()| to select a cert from
   // |matches_|, which will be stored in |selected_cert_|.
   // Will call back to |GotSelection()|.
   void SelectCerts() {
     CHECK(interactive_);
     if (matches_.empty()) {
       // Don't show a select dialog if no certificate is matching.
@@ skipping 249 matching lines @@
     const GetPlatformKeysCallback& callback,
     scoped_ptr<base::Value> value) {
   scoped_ptr<KeyEntries> key_entries(new KeyEntries);
   if (value)
     key_entries = KeyEntriesFromState(*value);
 
   callback.Run(key_entries.Pass());
 }
 
 }  // namespace chromeos