chrome.platformKeys: Add filtering by certificate types

chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/platform_keys/platform_keys.h"
 
 #include <cert.h>
 #include <cryptohi.h>
 #include <keyhi.h>
 #include <secder.h>
@@ skipping 740 matching lines @@
   // Get the pointer to |state| before base::Passed releases |state|.
   NSSOperationState* state_ptr = state.get();
 
   // The NSSCertDatabase object is not required. But in case it's not available
   // we would get more informative error messages and we can double check that
   // we use a key of the correct token.
   GetCertDatabase(token_id, base::Bind(&SignRSAWithDB, base::Passed(&state)),
                   browser_context, state_ptr);
 }
 
 void SelectClientCertificates(const ClientCertificateRequest& request,

[pneubeck (no reviews), 2015/05/19 10:09:00]

please check and update the documentation of this SelectClientCertificates in
platform_keys.h .

You should also change the |request| argument from  ClientCertificateRequest to
the type of certificate_authorities (as const&).

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

                               const SelectCertificatesCallback& callback,
                               content::BrowserContext* browser_context) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   scoped_refptr<net::SSLCertRequestInfo> cert_request_info(
       new net::SSLCertRequestInfo);
-  cert_request_info->cert_key_types = request.certificate_key_types;
+
+  // Currently we omit passing down the requested certificate type to the NSS

[pneubeck (no reviews), 2015/05/19 10:09:00]

s/NSS/net/

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+  // layer, as NSS does not support filtering certificates by type. Rather we

[pneubeck (no reviews), 2015/05/19 10:09:00]

s/NSS/it/

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

+  // retrieve certificates of all types and perform the filtering in
+  // PlaformKeysService::GotMatchingCerts().

[pneubeck (no reviews), 2015/05/19 10:09:00]

... of all type and the caller has to apply filtering afterwards.

[cschuet (SLOW), 2015/05/19 11:36:23]

Done.

   cert_request_info->cert_authorities = request.certificate_authorities;
 
   const user_manager::User* user =
       chromeos::ProfileHelper::Get()->GetUserByProfile(
           Profile::FromBrowserContext(browser_context));
 
   // Use the device-wide system key slot only if the user is of the same
   // domain as the device is registered to.
   policy::BrowserPolicyConnectorChromeOS* connector =
       g_browser_process->platform_part()->browser_policy_connector_chromeos();
@@ skipping 109 matching lines @@
   NSSOperationState* state_ptr = state.get();
   GetCertDatabase(std::string() /* don't get any specific slot */,
                   base::Bind(&GetTokensWithDB, base::Passed(&state)),
                   browser_context,
                   state_ptr);
 }
 
 }  // namespace platform_keys
 
 }  // namespace chromeos