Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc

Issue 1141253003: chrome.platformKeys: Add filtering by certificate types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed pneubeck's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
diff --git a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
index a7ce5b5d6adb9f3489c19ea060efe419aa65dc6f..d6887d5f8152ef4bcec69804e27ac2da96f4d23d 100644
--- a/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
+++ b/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
@@ -758,15 +758,20 @@ void SignRSAPKCS1Raw(const std::string& token_id,
browser_context, state_ptr);
}
-void SelectClientCertificates(const ClientCertificateRequest& request,
- const SelectCertificatesCallback& callback,
- content::BrowserContext* browser_context) {
+void SelectClientCertificates(
+ const std::vector<std::string>& certificate_authorities,
+ const SelectCertificatesCallback& callback,
+ content::BrowserContext* browser_context) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
scoped_refptr<net::SSLCertRequestInfo> cert_request_info(
new net::SSLCertRequestInfo);
- cert_request_info->cert_key_types = request.certificate_key_types;
- cert_request_info->cert_authorities = request.certificate_authorities;
+
+ // Currently we do not pass down the requested certificate type to the net
+ // layer, as it does not support filtering certificates by type. Rather, we
+ // do not constrain the certificate type here, instead the caller has to apply
+ // filtering afterwards.
+ cert_request_info->cert_authorities = certificate_authorities;
const user_manager::User* user =
chromeos::ProfileHelper::Get()->GetUserByProfile(
« no previous file with comments | « chrome/browser/chromeos/platform_keys/platform_keys.h ('k') | chrome/browser/chromeos/platform_keys/platform_keys_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698