utils/apidoc/apidoc.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/apidoc/apidoc.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment in https://codereview.chromium.org/11365196/diff/6001/pkg/intl/lib/date_format.dart Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/apidoc/apidoc.dart

diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart

index 785c497b46fe6438e93d9e7dd7a7b360af234185..11246dd362fda0624c806eb495f50a81803142ea 100644

--- a/utils/apidoc/apidoc.dart

+++ b/utils/apidoc/apidoc.dart

@@ -384,7 +384,7 @@ class Apidoc extends doc.Dartdoc {

doc.DocComment createDocComment(String text,

[ClassMirror inheritedFrom]) {

String strippedText =

- text.replaceAll(const RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)"),

+ text.replaceAll(new RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)"),

'').trim();

if (strippedText.isEmpty) return null;

return super.createDocComment(strippedText, inheritedFrom);