utils/apidoc/html_diff.dart - Issue 11410033: Make RegExp's constructor non-const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/apidoc/html_diff.dart

Issue 11410033: Make RegExp's constructor non-const. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment in https://codereview.chromium.org/11365196/diff/6001/pkg/intl/lib/date_format.dart Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: utils/apidoc/html_diff.dart

diff --git a/utils/apidoc/html_diff.dart b/utils/apidoc/html_diff.dart

index 130666d2b9ae9e76aadf69c60c7fcd2856bc5c62..5d209bba73bba4a0553f66a5aa88a742c746d61d 100644

--- a/utils/apidoc/html_diff.dart

+++ b/utils/apidoc/html_diff.dart

@@ -228,7 +228,7 @@ class HtmlDiff {

Map<String, String> _getTags(String comment) {

if (comment == null) return const <String, String>{};

- final re = const RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");

+ final re = new RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");

final tags = <String, String>{};

for (var m in re.allMatches(comment.trim())) {

tags[m[1]] = m[2];